fix(slow_subs): Fix the unit error of the deliver_begin_at timestamp
#8981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
requested changes
Sep 16, 2022
lafirest
force-pushed
the
v4.4
branch
2 times, most recently
from
fe386aa
to
f8c17a4
Compare
HJianBo
previously approved these changes
Sep 23, 2022
There was a problem hiding this comment.
LGTM; Could you plz check it again? @zmstone @xiangfangyang-tech
ieQu1
previously approved these changes
Sep 23, 2022
xiangfangyang-tech
previously approved these changes
Sep 26, 2022
The unit of `deliver_begin_at` is incorrectly used the seconds, this will cause the `internal` stat type to never working and the `response` type time span error
lafirest
dismissed stale reviews from xiangfangyang-tech, ieQu1, and HJianBo
via
6fd0261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit of
deliver_begin_atis incorrectly used theseconds, the resulting is incorrect whenstats_typeisinternalorresponse.When
stats_typeisinternal, the time span is always negative (seconds - milliseconds) and will not be countedWhen
stats_typeisresponse, the time span is a large value (milliseconds - seconds)