test: fix more flaky test in share sub SUITE #9088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
approved these changes
Oct 3, 2022
id
reviewed
Oct 3, 2022
id
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to start emqx_modules application in ct-slave tests.
This is due to enterprise edition needs emqx_modules to be running since https://github.com/emqx/emqx-enterprise/pull/1400/commits/f5d5b41e0116b977a3a217a6088e81caadbaddd9
Some more fixes for flakyness:
okotherwise error get silently ignored, no way to know what went wrongstarted_not_connected, we allow it, and thepingin the next line should make sure the nodes are connected