Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refresh resources and rules asynchronously #9199

Merged
merged 3 commits into from
Oct 26, 2022
Merged

fix: refresh resources and rules asynchronously #9199

merged 3 commits into from
Oct 26, 2022

Conversation

terry-xiaoyu
Copy link
Contributor

This is to avoid blocking the start of the emqx_rule_engine app if some of the resources spent too long time on establishing the connection.

@terry-xiaoyu terry-xiaoyu force-pushed the boot_blocked_by_unreachable_resources branch from 556a098 to a56b3b3 Compare October 24, 2022 05:58
@terry-xiaoyu
Copy link
Contributor Author

I have tested rolling upgrade on my PC.

zmstone
zmstone reviewed Oct 24, 2022
View reviewed changes
changes/v4.3.22-en.md Outdated Show resolved Hide resolved
changes/v4.3.22-en.md Outdated Show resolved Hide resolved
changes/v4.3.22-zh.md Outdated Show resolved Hide resolved
changes/v4.3.22-zh.md Outdated Show resolved Hide resolved
apps/emqx_rule_engine/src/emqx_rule_monitor.erl Show resolved Hide resolved
apps/emqx_rule_engine/src/emqx_rule_engine.erl Show resolved Hide resolved
apps/emqx_rule_engine/src/emqx_rule_engine.erl Show resolved Hide resolved
@terry-xiaoyu terry-xiaoyu force-pushed the boot_blocked_by_unreachable_resources branch from a56b3b3 to 9f18c96 Compare October 24, 2022 13:32
@terry-xiaoyu terry-xiaoyu force-pushed the boot_blocked_by_unreachable_resources branch 2 times, most recently from e91f31a to e265f65 Compare October 25, 2022 11:43
zmstone
zmstone reviewed Oct 25, 2022
View reviewed changes
changes/v4.3.22-en.md Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Oct 25, 2022
View reviewed changes
changes/v4.3.22-zh.md Outdated Show resolved Hide resolved
@terry-xiaoyu terry-xiaoyu force-pushed the boot_blocked_by_unreachable_resources branch from e265f65 to 006d2e5 Compare October 25, 2022 12:41
@terry-xiaoyu terry-xiaoyu mentioned this pull request Oct 25, 2022
Closed
@terry-xiaoyu terry-xiaoyu merged commit 90ef925 into emqx:main-v4.3 Oct 26, 2022
@terry-xiaoyu terry-xiaoyu deleted the boot_blocked_by_unreachable_resources branch October 26, 2022 05:41
xiangfangyang-tech
xiangfangyang-tech reviewed Oct 26, 2022
View reviewed changes
Copy link
Contributor

@xiangfangyang-tech xiangfangyang-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested good without hot upgrade. hot upgrade will be done in integration test.

@terry-xiaoyu terry-xiaoyu mentioned this pull request Nov 9, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangfangyang-tech xiangfangyang-tech xiangfangyang-tech left review comments

@zmstone zmstone zmstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terry-xiaoyu @zmstone @xiangfangyang-tech