Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make init_resource_with_retrier/4 only 'throw' when failed #9334

Merged

Conversation

terry-xiaoyu
Copy link
Contributor

The return value and failure pattern of init_resource_with_retrier/4 should be the same as init_resource/4.
The issue was introduced by this one: #9199

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

thalesmg
thalesmg previously approved these changes Nov 9, 2022
@terry-xiaoyu terry-xiaoyu force-pushed the fix_500_when_resource_unavailable branch from c8bba94 to 6725a36 Compare November 10, 2022 03:31
Copy link
Contributor

@xiangfangyang-tech xiangfangyang-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested good

@terry-xiaoyu terry-xiaoyu merged commit 89b6cce into emqx:release-v43 Nov 10, 2022
@terry-xiaoyu terry-xiaoyu deleted the fix_500_when_resource_unavailable branch November 10, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants