Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add jwt worker for rule actions #9241

Merged
merged 9 commits into from
Nov 4, 2022
Merged

feat: add jwt worker for rule actions #9241

merged 9 commits into from
Nov 4, 2022

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Oct 26, 2022 •
edited
Loading

Will be used in GCP PubSub resource for EE.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change, and another jira tickt to track doc updates (if any) (EMQX-7918)
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

@thalesmg thalesmg force-pushed the rule-jwt-worker-v44 branch 5 times, most recently from 295252b to e63926e Compare October 27, 2022 14:10
@thalesmg thalesmg marked this pull request as ready for review October 27, 2022 14:35
zmstone
zmstone reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not done yet.

changes/v4.4.11-en.md Show resolved Hide resolved
changes/v4.4.11-zh.md Show resolved Hide resolved
apps/emqx_rule_engine/src/emqx_rule_engine_jwt_sup.erl Outdated Show resolved Hide resolved
apps/emqx_rule_engine/src/emqx_rule_engine_jwt_sup.erl Outdated Show resolved Hide resolved
apps/emqx_rule_engine/src/emqx_rule_engine_jwt_worker.erl Outdated Show resolved Hide resolved
@thalesmg
Copy link
Contributor Author

Marking this as draft just to avoid accidental merge before the code freeze.

Otherwise, it can be already reviewed.

@thalesmg thalesmg marked this pull request as draft October 27, 2022 18:46
@thalesmg thalesmg force-pushed the rule-jwt-worker-v44 branch 2 times, most recently from 4c2d129 to 966d73c Compare October 28, 2022 13:19
@thalesmg thalesmg requested a review from a team October 28, 2022 16:24
@thalesmg thalesmg force-pushed the rule-jwt-worker-v44 branch 5 times, most recently from c2d23e4 to 79b95a3 Compare October 31, 2022 19:19
@thalesmg thalesmg requested a review from a team November 1, 2022 16:29
@zmstone
Copy link
Member

zmstone commented Nov 2, 2022

LGTM.
Only a few minor comments.

zmstone
zmstone previously approved these changes Nov 4, 2022
View reviewed changes
@zmstone zmstone marked this pull request as ready for review November 4, 2022 12:32
@zmstone zmstone changed the base branch from main-v4.4 to release-v44 November 4, 2022 12:35
@zmstone zmstone dismissed their stale review November 4, 2022 12:35

The base branch was changed.

@thalesmg thalesmg requested a review from zmstone November 4, 2022 12:47
@zmstone zmstone merged commit 746cdef into emqx:release-v44 Nov 4, 2022
@thalesmg thalesmg deleted the rule-jwt-worker-v44 branch November 4, 2022 13:23
@thalesmg thalesmg mentioned this pull request Dec 8, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thalesmg @zmstone