Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move to /authorization/sources/built_in_database/rules #9569

Conversation

sstrigler
Copy link
Contributor

@sstrigler sstrigler commented Dec 16, 2022

Fixes EMQX-8372

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For internal contributor: there is a jira ticket to track this change
  • Coordinate with Dashboard-Team

@sstrigler sstrigler force-pushed the EMQX-8372-5-0-refactor-delete-authorization-sources-built-in-database-purge-all branch from ee37f6d to 6994013 Compare December 16, 2022 14:02
@sstrigler
Copy link
Contributor Author

@lafirest could you help with translations please?

@sstrigler sstrigler force-pushed the EMQX-8372-5-0-refactor-delete-authorization-sources-built-in-database-purge-all branch from 6994013 to c43d01f Compare December 16, 2022 14:36
changes/v5.0.13-zh.md Outdated Show resolved Hide resolved
@sstrigler sstrigler marked this pull request as draft December 19, 2022 08:30
@sstrigler sstrigler force-pushed the EMQX-8372-5-0-refactor-delete-authorization-sources-built-in-database-purge-all branch 4 times, most recently from 2e6f5aa to 1459067 Compare December 19, 2022 15:44
@sstrigler sstrigler marked this pull request as ready for review December 19, 2022 16:03
@sstrigler sstrigler changed the base branch from master to dev/api-refactor December 20, 2022 08:37
@sstrigler sstrigler force-pushed the EMQX-8372-5-0-refactor-delete-authorization-sources-built-in-database-purge-all branch 2 times, most recently from 6e448ac to 809e40f Compare December 22, 2022 13:58
@id
Copy link
Collaborator

id commented Dec 27, 2022

@sstrigler please rebase on latest master to unblock windows and macos builds

@sstrigler sstrigler force-pushed the EMQX-8372-5-0-refactor-delete-authorization-sources-built-in-database-purge-all branch 3 times, most recently from 7010cff to 96c0b9e Compare January 9, 2023 09:48
@thalesmg
Copy link
Contributor

thalesmg commented Jan 9, 2023

I think the base branch needs to merge or rebase with master, because the way changelogs are constructed has changed: #9682

@sstrigler
Copy link
Contributor Author

I think the base branch needs to merge or rebase with master, because the way changelogs are constructed has changed: #9682

My idea is to merge all things into dev/api-refactor first and then fix it there before we merge the integration branch.

@sstrigler sstrigler force-pushed the EMQX-8372-5-0-refactor-delete-authorization-sources-built-in-database-purge-all branch from 96c0b9e to fe5a792 Compare January 9, 2023 13:38
changes/v5.0.13-zh.md Outdated Show resolved Hide resolved
apps/emqx_authz/i18n/emqx_authz_api_mnesia_i18n.conf Outdated Show resolved Hide resolved
@sstrigler sstrigler force-pushed the EMQX-8372-5-0-refactor-delete-authorization-sources-built-in-database-purge-all branch from fe5a792 to f27f573 Compare January 10, 2023 10:00
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3882208365

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 36 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.001%) to 79.897%

Files with Coverage Reduction New Missed Lines %
apps/emqx_authn/src/simple_authn/emqx_authn_jwt.erl 1 85.8%
apps/emqx_resource/src/emqx_resource_worker.erl 1 86.61%
apps/emqx/src/emqx_cm.erl 1 90.83%
apps/emqx/src/emqx_config.erl 1 84.09%
apps/emqx/src/emqx_connection.erl 1 88.18%
apps/emqx/src/emqx_flapping.erl 1 85.11%
apps/emqx/src/emqx_limiter/src/emqx_limiter_server.erl 1 89.08%
apps/emqx/src/emqx_os_mon.erl 1 84.06%
apps/emqx/src/emqx_stats.erl 1 91.67%
apps/emqx/src/emqx_alarm.erl 2 91.82%
Totals Coverage Status
Change from base Build 3873760495: 0.001%
Covered Lines: 22860
Relevant Lines: 28612

💛 - Coveralls

@sstrigler sstrigler merged commit f54f238 into emqx:dev/api-refactor Jan 10, 2023
@sstrigler sstrigler deleted the EMQX-8372-5-0-refactor-delete-authorization-sources-built-in-database-purge-all branch February 17, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants