Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Change how the changelog is created #9682

Merged
merged 2 commits into from
Jan 5, 2023
Merged

ci: Change how the changelog is created #9682

merged 2 commits into from
Jan 5, 2023

Conversation

ieQu1
Copy link
Member

@ieQu1 ieQu1 commented Jan 4, 2023

No description provided.

@ieQu1 ieQu1 marked this pull request as ready for review January 4, 2023 20:39
@ieQu1 ieQu1 requested review from a team and id as code owners January 4, 2023 20:39
thalesmg
thalesmg previously approved these changes Jan 4, 2023
View reviewed changes
lafirest
lafirest reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@lafirest lafirest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better if we can auto-call the format-changelog.sh in the release script

@ieQu1
Copy link
Member Author

ieQu1 commented Jan 5, 2023

I think it might be better if we can auto-call the format-changelog.sh in the release script

Thanks for the remark, I added it to rel/cut script

id
id previously approved these changes Jan 5, 2023
View reviewed changes
@ieQu1 ieQu1 requested a review from id January 5, 2023 12:29
@ieQu1 ieQu1 merged commit 32922a6 into emqx:master Jan 5, 2023
@thalesmg thalesmg mentioned this pull request Jan 9, 2023
Merged
5 tasks
@id
Copy link
Collaborator

id commented Jan 31, 2023

@ieQu1 we missed #9676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lafirest lafirest lafirest left review comments

@id id id approved these changes

@qzhuyan qzhuyan qzhuyan approved these changes

@thalesmg thalesmg thalesmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ieQu1 @id @qzhuyan @thalesmg @lafirest