fix: infinite recursion in mysql connector and improve mysql EE bridge tests #9571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olcai
force-pushed
the
improve-mysql-bridge-test
branch
from
98096c9
to
ed4aec1
Compare
olcai
commented
Dec 20, 2022
thalesmg
previously approved these changes
Dec 20, 2022
olcai
force-pushed
the
improve-mysql-bridge-test
branch
from
e547848
to
c683d1f
Compare
qzhuyan
reviewed
Dec 21, 2022
thalesmg
previously approved these changes
Dec 21, 2022
zmstone
reviewed
Dec 21, 2022
| @@ -305,6 +315,8 @@ prepare_sql_to_conn(Conn, [{Key, SQL} | PrepareList]) when is_pid(Conn) -> | |||
| ?SLOG(info, LogMeta#{result => success}), | |||
| prepare_sql_to_conn(Conn, PrepareList); | |||
| {error, Reason} -> | |||
| % FIXME: we should try to differ on transient failers and | |||
There was a problem hiding this comment.
I took a shot at it but came to the conclusion that it might require a more thorough refactor. The code is hard to follow as-is and already has several layers of error coping mechanisms, and these should be unified. Created EMQX-8582 to track it.
An infinite loop was triggered in the mysql connector when a query used a prepared statement key that was not among the defined prepared statements on start. We now check that the key is defined among the prepared statements before recursing. It seems that this bug was never triggered in any production code flow and simply found while writing tests. An error return spell fix is also included as well as a FIXME comment regarding running mysql:prepare and not distinguishing between transient failures and syntax errors. Syntax errors should not be retried.
Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
olcai
force-pushed
the
improve-mysql-bridge-test
branch
from
c6a8dfd
to
13942f5
Compare
Pull Request Test Coverage Report for Build 3756578837
💛 - Coveralls |
zmstone
approved these changes
Dec 22, 2022
|
the slim build fails will be fixed in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of EMQX-7923 and implements further EE mysql bridge tests covering:
A bug was found while implementing tests regarding prepared statements. An infinite loop was triggered in the mysql connector when a query used a prepared statement key that was not among the defined prepared statements on start. We now check that the key is defined among the prepared statements before recursing. It seems that this bug was never
triggered in any production code.
Fixes EMQX-8414.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/dir