Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: infinite recursion in mysql connector and improve mysql EE bridge tests #9571

Merged
merged 6 commits into from
Dec 22, 2022
Merged

fix: infinite recursion in mysql connector and improve mysql EE bridge tests #9571

merged 6 commits into from
Dec 22, 2022

Commits on Dec 22, 2022

  1. fix(emqx_connector): check for key among prepared statements on query 

    An infinite loop was triggered in the mysql connector when a query
used a prepared statement key that was not among the defined prepared
statements on start. We now check that the key is defined among the
prepared statements before recursing. It seems that this bug was never
triggered in any production code flow and simply found while writing
tests.

An error return spell fix is also included as well as a FIXME comment
regarding running mysql:prepare and not distinguishing between
transient failures and syntax errors. Syntax errors should not be
retried.
    @olcai
    olcai committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    23ac426 View commit details
    Browse the repository at this point in the history

  2. test: add more EE mysql bridge test cases

    @olcai
    olcai committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    7df2400 View commit details
    Browse the repository at this point in the history

  3. chore: update changes

    @olcai
    olcai committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    d5a41b8 View commit details
    Browse the repository at this point in the history

  4. test: refactor EE mysql bridge test case 

    Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
    @olcai @thalesmg
    olcai and thalesmg committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    aab914d View commit details
    Browse the repository at this point in the history

  5. chore: update changes

    @olcai
    olcai committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    cc47ce0 View commit details
    Browse the repository at this point in the history

  6. refactor: rename error return in mysql connector

    @olcai
    olcai committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    13942f5 View commit details
    Browse the repository at this point in the history