Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

Possible config file parsing error #70

Closed
martinschayna opened this issue Apr 30, 2014 · 2 comments
Closed

Possible config file parsing error #70

martinschayna opened this issue Apr 30, 2014 · 2 comments
Labels

Comments

@martinschayna
Copy link

Hi,

currently my ~/.ssh/config file looks like this:

Host *
User ec2-user
IdentityFile ~/.ssh/my-cert.pem

Host dev-api
HostName ec2-...compute.amazonaws.com

Host dev-webapp
HostName ec2-...compute.amazonaws.com

I can simple put any host alias to ssh command without specifying ec2-user as username or any other options. Command storm list shows:

listing entries:

    dev-api -> local-user-name@ec2-...compute.amazonaws.com:22

    dev-webapp -> local-user-name@ec2-...compute.amazonaws.com:22

(*) -> identityfile:
    ~/.ssh/my-cert.pem
    user:ec2-user

You can see wrong local username in listing entries. It means that storm doesn't interpret asterisk in first Host entry as template for every other entries.

Can storm parse any config files and this is a bug, or can parse only config files managed by storm itself?

@emre
Copy link
Owner

emre commented Apr 30, 2014

we need to add a check for general (*) rules.

* is there a user info for entry? 
* if it doesn't exists, control general rules. if there is a user info there, take it. 
don't get machine's username as default.

currenty, it gets the working user's name if no user is specified.

storm should parse every possible SSHConfig, this seems like a bug. thanks for the feedback. I will work on that.

@martinschayna
Copy link
Author

Thanks. This is not a problem for me currently, I'm going to use storm for managing config too. Config file I mentioned was my old one.

@emre emre added the bug label Apr 30, 2014
@emre emre closed this as completed in 0d2d034 Jul 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants