Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handling of exported native globals (namedGlobals) #12371

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 29, 2020

And make them work with MINIMAL_RUNTIME.

This removes the need for a NAMED_GLOBALS variable and is
precursor to transitioning to the new PIC ABI

@sbc100 sbc100 changed the title Simply handling of exported native globals (namedGlobals) Simplify handling of exported native globals (namedGlobals) Sep 29, 2020
@sbc100 sbc100 requested a review from kripken September 29, 2020 20:05
tests/other/test_export_global_address.c Show resolved Hide resolved
src/settings_internal.js Outdated Show resolved Hide resolved
emscripten.py Show resolved Hide resolved
@sbc100 sbc100 force-pushed the named_globals_part1 branch 3 times, most recently from 0b2abe4 to 77ef6e8 Compare September 30, 2020 05:53
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 30, 2020

Ping

@sbc100 sbc100 requested a review from kripken October 1, 2020 04:08
emscripten.py Show resolved Hide resolved
src/postamble_minimal.js Outdated Show resolved Hide resolved
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, lgtm assuming tests don't show we've missed something...

And make them work with MINIMAL_RUNTIME.

This remove the use of the NAMED_GLOBALS variable and is
precursor to transitioning to the new PIC ABI
@sbc100 sbc100 merged commit 66d7b8c into master Oct 1, 2020
@sbc100 sbc100 deleted the named_globals_part1 branch October 1, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants