Split config file handling out of shared.py. NFC. #12699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
shared_python_refactor
branch
7 times, most recently
from
47cea7a
to
435c471
Compare
Move config file handling into its own file. Also, move a few small utilities into `utils.py` to avoid circular dependencies. For a while now shared.py has been way too big and this is step towards breaking it up and breaking the existing circular dependencies between python modules that use and also also used by shared.py (cache.py for example).
sbc100
force-pushed
the
shared_python_refactor
branch
from
435c471
to
3fcac17
Compare
kripken
approved these changes
Nov 9, 2020
sbc100
added a commit
that referenced
this pull request
Nov 10, 2020
emsdk was broken by #12699 because it was assuming that EM_CONFIG is available in the environment at the point when the config was bring parsed.
sbc100
added a commit
that referenced
this pull request
Nov 10, 2020
emsdk was broken by #12699 because it was assuming that EM_CONFIG is available in the environment at the point when the config was bring parsed.
sbc100
added a commit
that referenced
this pull request
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move config file handling into its own file. In order to achieve this
while avoiding a circular bependecy between shared.py and config.py,
move a few small utilities into
utils.py.For a while now
shared.pyhas been way too big and this is step towardsbreaking it up and breaking the existing circular dependencies between
python modules that use, and also also used by,
shared.py(cache.pyforexample).