emterpreter: support wildcards in EMTERPRETIFY_WHITELIST (#7988) #8056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Feb 11, 2019
ChangeLog.md
Outdated
| @@ -23,6 +23,10 @@ Current Trunk | |||
| ad hoc constructed rules around default Emscripten uses. The old behavior | |||
| will be deprecated and removed in the future. Build with -s ASSERTIONS=1 | |||
| to get diagnostics messages related to this transition. | |||
|
|
|||
| - Option -s EMTERPRETIFY_WHITELIST now accepts shell-style wildcards; | |||
There was a problem hiding this comment.
better to add new stuff on the top, as then when new releases are added, the new thing would not be at risk of being included by mistake in the wrong release. (I just added 1.38.27 now, so this will need to be moved)
|
Sure. ? |
|
Emterpretify runs on asm.js, and the wasm backend doesn't use asm.js as an intermediary stage, so it's not compatible with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. #7988
I used wildcards (not regexs) as it seems simpler, though this can be changed.