New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emterpreter: support wildcards in EMTERPRETIFY_WHITELIST (#7988) #8056

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@Beuc
Copy link
Contributor

Beuc commented Feb 10, 2019

Cf. #7988
I used wildcards (not regexs) as it seems simpler, though this can be changed.

@kripken
Copy link
Member

kripken left a comment

Thanks, looks good, but please add a test. Can maybe make an existing whitelist test run twice, once with a wildcard.

@@ -23,6 +23,10 @@ Current Trunk
ad hoc constructed rules around default Emscripten uses. The old behavior
will be deprecated and removed in the future. Build with -s ASSERTIONS=1
to get diagnostics messages related to this transition.

- Option -s EMTERPRETIFY_WHITELIST now accepts shell-style wildcards;

This comment has been minimized.

@kripken

kripken Feb 11, 2019

Member

better to add new stuff on the top, as then when new releases are added, the new thing would not be at risk of being included by mistake in the wrong release. (I just added 1.38.27 now, so this will need to be moved)

@Beuc

This comment has been minimized.

Copy link
Contributor Author

Beuc commented Feb 11, 2019

Sure.
Any reason why we use

  @no_wasm_backend('uses EMTERPRETIFY')

?

@Beuc Beuc force-pushed the Beuc:patch-3 branch from 66c4e1d to d1d6f0f Feb 11, 2019

@kripken

This comment has been minimized.

Copy link
Member

kripken commented Feb 12, 2019

Emterpretify runs on asm.js, and the wasm backend doesn't use asm.js as an intermediary stage, so it's not compatible with that.

@kripken kripken merged commit b007b1c into emscripten-core:incoming Feb 12, 2019

27 of 28 checks passed

ci/circleci: test-browser-firefox Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-upstream Your tests passed on CircleCI!
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: test-ab Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen0 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen1 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen2 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen3 Your tests passed on CircleCI!
Details
ci/circleci: test-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-c Your tests passed on CircleCI!
Details
ci/circleci: test-d Your tests passed on CircleCI!
Details
ci/circleci: test-e Your tests passed on CircleCI!
Details
ci/circleci: test-f Your tests passed on CircleCI!
Details
ci/circleci: test-ghi Your tests passed on CircleCI!
Details
ci/circleci: test-jklmno Your tests passed on CircleCI!
Details
ci/circleci: test-other Your tests passed on CircleCI!
Details
ci/circleci: test-p Your tests passed on CircleCI!
Details
ci/circleci: test-qrst Your tests passed on CircleCI!
Details
ci/circleci: test-sanity Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-binaryen0 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-binaryen2 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasmobj0 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasmobj2 Your tests passed on CircleCI!
Details
ci/circleci: test-uvwxyz Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment