Don't include printf %m support #8133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es strerror, which brings in 2.5K of strings in any program that uses printf
jgravelle-google
approved these changes
Feb 20, 2019
| @@ -595,8 +595,10 @@ static int printf_core(FILE *f, const char *fmt, va_list *ap, union arg *nl_arg, | |||
| *(a=z-(p=1))=arg.i; | |||
| fl &= ~ZERO_PAD; | |||
| break; | |||
| #ifndef __EMSCRIPTEN__ // 'm' is a gnu extension, and strerror brings in 2.5K of strings | |||
| case 'm': | |||
| if (1) a = strerror(errno); else | |||
There was a problem hiding this comment.
Have I mentioned that I think vfprintf is particularly kooky?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a gnu libc extension, which uses strerror, which brings in 2.5K of strings in any program that uses printf.
Simple hello world doesn't hit this, as
printf("hello, world!\n");is optimized toputs. But any program whereprintfsurvives the optimizer, evenprintf("%d\n", num);, did get this extra 2.5K... (edit: which was almost 15% of the size)