Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 8042 - _emscripten_traverse_stack updated #8159

Closed
wants to merge 5 commits into from

Conversation

woosle1234
Copy link

https://github.com/emscripten-core/emscripten/blob/incoming/src/library.js

Changed function _emscripten_traverse_stack in library.js
Could not replicate same functionality in strict mode, so I disabled the function by removing the code and replacing it with "return null;"

Ran random100 tests and passed, but I do not know what to add to runner.py if anything.

src/library.js Outdated Show resolved Hide resolved
@@ -4493,14 +4462,6 @@ LibraryManager.library = {
flags |= 16/*EM_LOG_JS_STACK*/;
}

var stack_args = null;
if (flags & 128 /*EM_LOG_FUNC_PARAMS*/) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think the code removals are all correct!

We should also remove the option EM_LOG_FUNC_PARAMS that was used here - I assume it's no longer used anywhere else? Please search for it in the entire codebase, we should update docs, remove it from the C header, etc., and also add a note to the Changelog that we are removing it. It's possible doing so will break a test, which we'll need ot fix.

I see this caused a test or two to fail, AssertionError: 1532 != 1533 etc. I think you just need to find those tests in the python code, and update that number to the new number - what happened here is you removed a function, and we track those (so we don't remove or add any by mistake - here it's ok of course). If you get stuck there let me help out, as that test can be tricky.

@sbc100 sbc100 closed this Jan 30, 2020
@sbc100
Copy link
Collaborator

sbc100 commented Jan 30, 2020

The deletion of the incoming branch triggered the automatic closing of this branch. My apologies. This was an unexpected side effect.

Re-opening and re-targeting to master.

@sbc100 sbc100 reopened this Jan 30, 2020
@sbc100 sbc100 changed the base branch from incoming to master January 30, 2020 22:05
@stale
Copy link

stale bot commented Jan 30, 2021

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Jan 30, 2021
Base automatically changed from master to main March 8, 2021 23:49
@stale stale bot removed the wontfix label Mar 8, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Apr 16, 2022
@stale stale bot closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants