Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 8042 - _emscripten_traverse_stack updated #8159

Open
wants to merge 7 commits into
base: incoming
from

Conversation

@woosle1234
Copy link

commented Feb 22, 2019

https://github.com/emscripten-core/emscripten/blob/incoming/src/library.js

Changed function _emscripten_traverse_stack in library.js
Could not replicate same functionality in strict mode, so I disabled the function by removing the code and replacing it with "return null;"

Ran random100 tests and passed, but I do not know what to add to runner.py if anything.

sbc100 and others added 6 commits Oct 19, 2018
Fix sqlite test
The _callback function being included in EXPORT_FUNCTIONS but it is
a static function which is not exportable with the wasm backend.
Since this is never used simply remove it from the list.
Revert "Fix sqlite test"
This reverts commit dbe1523 which
was mistakenly committed to master.
Woosle Park
src/library.js Outdated Show resolved Hide resolved
Woosle Park
@@ -4493,14 +4462,6 @@ LibraryManager.library = {
flags |= 16/*EM_LOG_JS_STACK*/;
}

var stack_args = null;
if (flags & 128 /*EM_LOG_FUNC_PARAMS*/) {

This comment has been minimized.

Copy link
@kripken

kripken Mar 4, 2019

Member

Thanks, I think the code removals are all correct!

We should also remove the option EM_LOG_FUNC_PARAMS that was used here - I assume it's no longer used anywhere else? Please search for it in the entire codebase, we should update docs, remove it from the C header, etc., and also add a note to the Changelog that we are removing it. It's possible doing so will break a test, which we'll need ot fix.

I see this caused a test or two to fail, AssertionError: 1532 != 1533 etc. I think you just need to find those tests in the python code, and update that number to the new number - what happened here is you removed a function, and we track those (so we don't remove or add any by mistake - here it's ok of course). If you get stuck there let me help out, as that test can be tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.