Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag NODEJS_CATCH_REJECTION to control handling of unhandled rejections in node #9061

Merged
merged 3 commits into from
Jul 26, 2019
Merged

Add a flag NODEJS_CATCH_REJECTION to control handling of unhandled rejections in node #9061

merged 3 commits into from
Jul 26, 2019

Commits on Jul 22, 2019

  1. Remove unhandledRejection handler from node.js. As a result, errors d… 

    …uring async instantiation may behave oddly (they hang for a few seconds, node warns this behavior will be fixed in the future, and it exits with a 0 returncode), which is a downside, but the upside is that it avoids confusion for developers that get the handler popping up when they didn't expect it. Alter a test to work around this. Fixes #7855, #9028.
    @kripken
    kripken committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    f132637 View commit details
    Browse the repository at this point in the history

  2. Revert "Remove unhandledRejection handler from node.js. As a result, … 

    …errors during async instantiation may behave oddly (they hang for a few seconds, node warns this behavior will be fixed in the future, and it exits with a 0 returncode), which is a downside, but the upside is that it avoids confusion for developers that get the handler popping up when they didn't expect it. Alter a test to work around this. Fixes #7855, #9028."

This reverts commit f132637.
    @kripken
    kripken committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    48c4b0f View commit details
    Browse the repository at this point in the history

  3. Add NODEJS_CATCH_REJECTION, a flag that allows disabling the catching… 

    … of unhandled rejections in node. This is useful if a dev doesn't want it to interfere with their own code. We don't set this to 0 by default because it would mean some wasm errors end up not returning a non-zero return code from node (still true as of 12.4.0)
    @kripken
    kripken committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    c07754f View commit details
    Browse the repository at this point in the history