-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unhandledRejection event listener #9028
Labels
Comments
I don't think there is a way to remove it right now.. isn't this a dup of #7855? |
Can't this be added? I don't see the point of keeping it |
kripken
added a commit
that referenced
this issue
Jul 22, 2019
…uring async instantiation may behave oddly (they hang for a few seconds, node warns this behavior will be fixed in the future, and it exits with a 0 returncode), which is a downside, but the upside is that it avoids confusion for developers that get the handler popping up when they didn't expect it. Alter a test to work around this. Fixes #7855, #9028.
kripken
added a commit
that referenced
this issue
Jul 22, 2019
…errors during async instantiation may behave oddly (they hang for a few seconds, node warns this behavior will be fixed in the future, and it exits with a 0 returncode), which is a downside, but the upside is that it avoids confusion for developers that get the handler popping up when they didn't expect it. Alter a test to work around this. Fixes #7855, #9028." This reverts commit f132637.
This was referenced Jul 22, 2019
kripken
added a commit
that referenced
this issue
Jul 26, 2019
…jections in node (#9061) * Add NODEJS_CATCH_REJECTION, a flag that allows disabling the catching of unhandled rejections in node. This is useful if a dev doesn't want it to interfere with their own code. We don't set this to 0 by default because it would mean some wasm errors end up not returning a non-zero return code from node (still true as of 12.4.0) Helps #7855, #9028
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant. |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this issue
Dec 23, 2020
…jections in node (emscripten-core#9061) * Add NODEJS_CATCH_REJECTION, a flag that allows disabling the catching of unhandled rejections in node. This is useful if a dev doesn't want it to interfere with their own code. We don't set this to 0 by default because it would mean some wasm errors end up not returning a non-zero return code from node (still true as of 12.4.0) Helps emscripten-core#7855, emscripten-core#9028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there a way to remove:
from the js bundle?
I tried
NODEJS_CATCH_EXIT=0
flag. But it does only removeprocess.on('uncaughtException')
.The text was updated successfully, but these errors were encountered: