Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please bump Node version on emscripten/emsdk #1303

Closed
skhaz opened this issue Nov 25, 2023 · 4 comments
Closed

Please bump Node version on emscripten/emsdk #1303

skhaz opened this issue Nov 25, 2023 · 4 comments

Comments

@skhaz
Copy link

skhaz commented Nov 25, 2023

Could it be possible to bump the Node version to the current LTS? The Docker image contains version 12, which is quite old.

@sbc100
Copy link
Collaborator

sbc100 commented Nov 27, 2023

Which docker images contains node 12? IIRC we updates for node 16 recently. See #1232.

Regarding updated from 16 to 18 (which is currently LTS) that has beed discussed at length in other issues such as #1173 and #1284. Since we landed #1189, the version of node used internally with emsdk should have less impact (since it not longer adds node to the path if there already exists one).

@skhaz
Copy link
Author

skhaz commented Nov 27, 2023

I have found Node 16 (not 12) on /emsdk/node/16.20.0_64bit/bin in emscripten/emsdk:3.1.49

@sbc100
Copy link
Collaborator

sbc100 commented Nov 27, 2023

Do you need run node within the emsdk docker container? Is node 16 sufficient for your purposes?

@skhaz
Copy link
Author

skhaz commented Nov 27, 2023

Yes, that's more than enough, I was using Node to run WebAssembly, but I changed my mind and will execute the WebAssembly with wasmtime because I have more control (I was using emscripten as base, to run a simple script in JavaScript).

Thank you!

@sbc100 sbc100 closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants