Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modbus UI not working correctly #1771

Closed
mheyse opened this issue May 18, 2024 · 2 comments
Closed

Modbus UI not working correctly #1771

mheyse opened this issue May 18, 2024 · 2 comments

Comments

@mheyse
Copy link
Contributor

mheyse commented May 18, 2024

PROBLEM DESCRIPTION

When enabling Modbus in Settings/Application only the port is pre-filled with the correct default value (502) - "Max Clients" and "Timeout" are empty.

REQUESTED INFORMATION

Built from commit 0c52fa1 with

cd interface
yarn install
yarn typesafe-i18n --no-watch
yarn build
yarn webUI
cd ..
pio run -e esp32_16M

TO REPRODUCE

Steps to reproduce the behavior:

EXPECTED BEHAVIOUR

Max Clients should be pre-filled with 10, Timeout with 1000 ms.

SCREENSHOTS

image
@proddy
Copy link
Contributor

proddy commented May 19, 2024

I'll take a look.

proddy added a commit to proddy/EMS-ESP32 that referenced this issue Jun 4, 2024
@proddy
merge with dev, fix emsesp#1771
363e84f
@proddy proddy mentioned this issue Jun 4, 2024
Merged
@proddy
Copy link
Contributor

proddy commented Jun 4, 2024

merged with latest dev
fixed the UI settings (changed maxClient and timeoutMillis also in C code)
made standalone compile

@proddy proddy closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@proddy @mheyse