Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign update & delete #32

Closed
DerAndereAndi opened this issue Nov 4, 2022 · 2 comments
Closed

Redesign update & delete #32

DerAndereAndi opened this issue Nov 4, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@DerAndereAndi
Copy link
Member

The current implementations requires lots of code duplications with minor adjustments which is error prone. Also it requires one hash key and does not allow different selectors, e.g. for electricalConnectionParameterDescriptionListData, to be used.

We should find a way to implement this in a generic way and define selectors e.g. using tags and correlations between filter selectors and datatypes e.g. using mapping constructs as done with functions and data types.

@DerAndereAndi DerAndereAndi added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Nov 4, 2022
@DerAndereAndi
Copy link
Member Author

I don't see a way to implement this in a generic way, as reflections won't provide the actual type as it only provides the underlying core type.

Hence the approach is to implement a generator that generates the code for all model types that require this.

@DerAndereAndi
Copy link
Member Author

This is implemented, found a mostly generic approach that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant