Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Textdomain, you are doing it wrong #1

Closed
w3guy opened this issue Jul 10, 2016 · 1 comment
Closed

Textdomain, you are doing it wrong #1

w3guy opened this issue Jul 10, 2016 · 1 comment

Comments

@w3guy
Copy link

w3guy commented Jul 10, 2016

You shouldn't be using tailor()->textdomain() as textdomain when using l10n / 118n functions.

http://ottopress.com/2012/internationalization-youre-probably-doing-it-wrong/
@andrew-worsfold
Copy link
Contributor

Thanks for this! I had replaced this for a majority of the strings in the plugin, but these got through. This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@w3guy @andrew-worsfold