Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop StaticFile app. #50

Closed
tomchristie opened this issue Aug 28, 2018 · 1 comment
Closed

Drop StaticFile app. #50

tomchristie opened this issue Aug 28, 2018 · 1 comment
Milestone
Version 1.0

Comments

@tomchristie
Copy link
Member

We have FileResponse and StaticFiles.

I think that including the StaticFile ASGI app complicates things unnecessarily, and that we should probably remove it.

  • Drop StaticFile app.
  • Put runtime checks that file exists, and file is a regular file in FileResponse.
@tomchristie tomchristie added this to the Version 1.0 milestone Aug 28, 2018
@tomchristie
Copy link
Member Author

Good one for a contributor to jump on here. 😎

@alexbotello alexbotello mentioned this issue Oct 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
1 participant
@tomchristie