Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing brace in for loop? #5

Closed
DoomT-AliW opened this issue Oct 21, 2019 · 1 comment
Closed

Missing brace in for loop? #5

DoomT-AliW opened this issue Oct 21, 2019 · 1 comment

Comments

@DoomT-AliW
Copy link

First just wanna say THANKS! Thanks for writing an API that just works. I expected to have to write only 2 lines of code from a usage stand point to create and apply a delta, and that's exactly what this API offers. Very nice usage interface. A breeze from all the over-engineered crap you usually see out there.

One thing I found is after downloading the source, there's a missing open brace for the for loop in Create(..)?

for (i = lenSrc - lenSrc % NHASH - NHASH; i >= 0; i -= NHASH)

Other than that it works great!

@DoomT-AliW DoomT-AliW changed the title Missing brace for for loop? Missing brace in for loop? Oct 21, 2019
@endel
Copy link
Owner

endel commented Oct 21, 2019

Hi @TTALIA, glad this library is serving some purpose to you! Apparently this problem has been introduced here https://github.com/endel/FossilDelta/pull/4/files

I'm not currently using this project anymore though, the source is not compiling because of this? Do you mind sending a PR fixing this?

Cheers!

@endel endel closed this as completed in 6ffa4fa Feb 17, 2020
endel added a commit that referenced this issue Feb 17, 2020
fixed #5 Missing brace in for loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants