Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster/NPC Traits should have their own item type? #245

Open
FoxLee opened this issue Oct 4, 2022 · 3 comments
Open

Monster/NPC Traits should have their own item type? #245

FoxLee opened this issue Oct 4, 2022 · 3 comments

Comments

@FoxLee
Copy link
Contributor

FoxLee commented Oct 4, 2022

Currently, there's no "correct" way to add Traits (as in, static properties like auras) to a creature using the NPC sheet/model. Presumably we've all been working around this by choosing some other "close enough" item—probably Feats or Class Features—but since there's no right choice this invites confusion and inconsistent data entry. Aside from just being annoying in its wrong-ness, this could potentially cause trouble with future development, so I think we should fix it before then.

Basically I'm proposing we add a new item (as in Foundry data entity) type for NPC Trait. It would be pretty simple—effectively a copy of Feat without the pre-req field. The level field isn't strictly necessary, but it may be worth having in order to facilitate level-appropriate "remixing" of monsters.

As well as removing the ambiguity and allowing for consistent data entry, this would get rid of all the unnecessary clutter on the NPC sheet's Features tab. (Whether the current one, or a potential new version.)

This is something I can probably work on myself, but since it would have a significant impact on how NPCs are constructed, I wanted to run the idea by other folks here (especially @draconas1 and their importer) before I do anything.

@draconas1
Copy link
Contributor

draconas1 commented Oct 4, 2022

So I personally don't like it because it adds another type that is not really behaviourally different from Class Feature, Race Feature, Paragon Path, Epic Destiny etc... And of course it's work for me to update the importer.

That doesn't mean that you are not absolutely correct that it's a more correct implementation for monsters, I am just not convinced that at this stage the effort involved is worth it.

@FoxLee
Copy link
Contributor Author

FoxLee commented Oct 5, 2022

Honestly I would be even happier to see all "features" collapsed into a single item model with a "type" selector for Class/Race/Path/Destiny/Background/Theme/Feat/Trait/Other, since they are all almost the exact same thing. (Well, I guess "ClassFeats" currently has the basic parameters tab, but IIRC that's just a holdover from the 5e implementation and doesn't actually work in 4e?) But that would be even more work, right?

@FoxLee
Copy link
Contributor Author

FoxLee commented Oct 8, 2022

Actually, working on NPC sheets today I've remembered that Traits do have some important properties that make them distinct from the various types of PC Features—the need to attach keywords, and the ability to be an aura. That sort of means they actually have more reason to exist as unique objects than the array of features do.

Of course you can enter that info in the description text and/or name field, but that's kinda hacky and makes it purely cosmetic. Getting real fields in there would open the door to checking/manipulating that data via the system (like for automation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants