[NewProduct] Motorola Mobility #1453

moviuro · 2022-08-02T10:16:02Z

Used the /we/ pages where available ("Rest of Europe"); /us/ otherwise; and if still that fails, anything goes.
No link for "moto g9", "moto e (2020)", "motorola one 5G UW ACE", "motorola one fusion"

products/motorola.md

captn3m0 · 2022-08-02T12:03:34Z

Could you add use a releaseLabel/releaseCycle split, similar to #1340. That will ensure that the data is available cleanly over the API.

releaseCycle should be the kebab-case version of the current name being used. (moto-g-pro, moto-g-power-2022 etc)

captn3m0 · 2022-10-17T12:10:32Z

@moviuro What's the source for the release dates in this PR?

moviuro · 2022-10-17T14:47:10Z

Release dates were pulled from individual pages about system updates: https://motorola-global-en-roe.custhelp.com/app/software-security-update/g_id/7112 -> "Select your Product" -> [Pick a product]

Motorola edge+ (2022) says:

Currently receiving regular security updates.

Device launched on February, 2022

Security updates will stop on February, 2025

captn3m0 · 2022-10-17T16:00:32Z

Thanks. I generated an updated version here: https://gist.github.com/captn3m0/069b0fd5879b8a1a549a7dfc45634173, that might be helpful in updating this PR.

I think we can add a activeSupport column, similar to how we're tracking it for Samsung Mobiles. If Motorola is promising a "Next Android", then we can mark it as actively supported.

captn3m0 · 2022-10-17T16:27:48Z

Okay, looks like we're still at 67 devices.

usta · 2022-10-18T00:25:14Z

@captn3m0 can we change this to something like this [adding as root component] ->
releaseLabel: {{"__RELEASE_CYCLE__" | replace:'-',' '}}
and remove all releaseLabel: tags which doesnt need modification ( just like (year) parts)
this will cleanup .md file's duplicated parts like

-   releaseCycle: "moto-g-pro"
    releaseLabel: "moto g pro"

usta

^^

captn3m0 · 2022-10-18T08:03:28Z

Let me give that a try

usta

link problem ( just tried one of them and for my luck it gived me 404 :D )

usta · 2022-10-18T09:45:06Z

products/motorola.md

+    releaseDate: 2022-08-01
+    eol: 2025-08-01
+    support: true
+    link: https://www.motorola.in/smartphones-moto-g32/p


Could be replaced by https://www.motorola.com/we/smartphones-moto-g-32/p ?

Used the /we/ pages where available ("Rest of Europe"); /us/ otherwise; and if still that fails, anything goes. No link for "moto g9", "moto e (2020)", "motorola one 5G UW ACE", "motorola one fusion"

Co-authored-by: Nemo <commits@captnemo.in>

Good luck to Motorola owners. Co-authored-by: Nemo <commits@captnemo.in>

marcwrobel · 2022-12-12T14:29:35Z

This PR was rather old. I just rebased from master.

marcwrobel · 2022-12-12T14:47:35Z

Just checked all the links, everything is OK except these:

captn3m0 · 2022-12-15T11:15:29Z

But overall looks like it will be a page difficult to maintain !

Agreed. This is also true of other device pages - Samsung, NVIDIA.

I tried to write some code to scrape dates from the Motorala website, but it didn't work out - too much complexity in how the pages are rendered.

focusing on other PRs, will let others review this instead.

marcwrobel · 2022-12-27T18:16:44Z

products/motorola.md

+    releaseLabel: "moto g play (2021)"
+    releaseDate: 2021-01-01
+    eol: 2023-01-01
+    link: https://www.motorola.com/we/smartphones-moto-g-play/p


404, could be replaced by https://www.motorola.com/us/smartphones-moto-g-play/p ?

marcwrobel · 2022-12-27T18:18:07Z

products/motorola.md

+    releaseDate: 2022-08-01
+    eol: 2025-08-01
+    support: true
+    link: https://www.motorola.in/smartphones-moto-g32/p


Could be replaced by https://www.motorola.com/we/smartphones-moto-g-32/p ?

marcwrobel · 2022-12-27T18:18:31Z

products/motorola.md

+    releaseLabel: "moto g power (2021)"
+    releaseDate: 2021-01-01
+    eol: 2023-01-01
+    link: https://www.motorola.com/us/smartphones-moto-g-power/p


404, could be replaced by https://www.motorola.com/us/smartphones-moto-g-power-gen-2/p ?

marcwrobel · 2022-12-27T18:20:02Z

products/motorola.md

+    releaseLabel: "motorola razr 5g"
+    releaseDate: 2020-09-01
+    eol: 2022-09-01
+    link: https://www.motorola.com/we/smartphones-razr-5g


Link looks wrong, it returns a server error page.

marcwrobel · 2022-12-27T18:20:41Z

products/motorola.md

+    releaseLabel: "moto g stylus"
+    releaseDate: 2020-04-01
+    eol: 2022-04-01
+    link: https://www.motorola.com/us/smartphones-moto-g-stylus/p


Redirected to https://www.motorola.com/us/smartphones-moto-g-stylus-gen-2/p?skuId=534, is it OK ?

marcwrobel · 2022-12-27T18:23:41Z

products/motorola.md

+category: device
+iconSlug: motorola
+releasePolicyLink: https://motorola-global-en-roe.custhelp.com/app/software-upgrade/
+activeSupportColumn: true


activeSupportColumn: true means support must be explicitly set for all release cycles.

This is required by :

endoflife.date/_auto/validate.py

Line 55 in 9a11b2e

assert isinstance(r["support"], (bool, date))

marcwrobel · 2022-12-27T18:26:04Z

I converted my earlier comments to proper review comments.

usta · 2023-02-10T23:50:55Z

@marcwrobel could you commit your requested changes on this PR whenever you have free time ?
This PR is waiting here for too long time. Lets we make your suggestions and merge it

marcwrobel · 2023-02-13T09:03:26Z

@marcwrobel could you commit your requested changes on this PR whenever you have free time ?
This PR is waiting here for too long time. Lets we make your suggestions and merge it

Like @captn3m0 I am focusing on other PRs, feel free to review / apply my suggestions.

marcwrobel · 2023-10-12T19:54:29Z

Closing this PR as nothing happened since more than 6 months (sources still available on https://github.com/moviuro/endoflife.date/tree/motorola).

captn3m0 previously requested changes Aug 2, 2022

View reviewed changes

products/motorola.md Outdated Show resolved Hide resolved

products/motorola.md Outdated Show resolved Hide resolved

usta changed the title ~~New page: motorola.md~~ [NewProduct] Motorola Mobility Aug 4, 2022

usta added the new-product This PR adds a new product to the website. label Aug 4, 2022

captn3m0 self-requested a review October 17, 2022 16:39

usta requested changes Oct 18, 2022

View reviewed changes

moviuro and others added 7 commits December 12, 2022 15:24

New page: motorola.md

82aef2d

Used the /we/ pages where available ("Rest of Europe"); /us/ otherwise; and if still that fails, anything goes. No link for "moto g9", "moto e (2020)", "motorola one 5G UW ACE", "motorola one fusion"

motorola.md: Focusing on the product, not the company

f5a96b5

Co-authored-by: Nemo <commits@captnemo.in>

motorola.md: some updates are pending "partner approval"

cb821a5

Good luck to Motorola owners. Co-authored-by: Nemo <commits@captnemo.in>

Motorola -> Motorola Mobility

ed22fe4

[motorola] Use releaseLabel

a54db64

Update motorola.md

77dfe58

[Motorola Mobility] Add missing new line in frontmatter

0bb57f1

marcwrobel force-pushed the motorola branch from f2ac527 to 0bb57f1 Compare December 12, 2022 14:28

marcwrobel mentioned this pull request Dec 12, 2022

Validate Frontmatter / validate check is not mandatory for merging PRs #1979

Closed

marcwrobel requested changes Dec 27, 2022

View reviewed changes

marcwrobel closed this Oct 12, 2023

Gamble81 approved these changes Apr 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NewProduct] Motorola Mobility #1453

[NewProduct] Motorola Mobility #1453

moviuro commented Aug 2, 2022

captn3m0 commented Aug 2, 2022

captn3m0 commented Oct 17, 2022

moviuro commented Oct 17, 2022

captn3m0 commented Oct 17, 2022

captn3m0 commented Oct 17, 2022

usta commented Oct 18, 2022 •

edited

Loading

usta left a comment

captn3m0 commented Oct 18, 2022

usta left a comment

usta Oct 18, 2022

marcwrobel Dec 27, 2022

marcwrobel commented Dec 12, 2022

marcwrobel commented Dec 12, 2022

captn3m0 commented Dec 15, 2022

marcwrobel Dec 27, 2022

marcwrobel Dec 27, 2022

marcwrobel Dec 27, 2022

marcwrobel Dec 27, 2022

marcwrobel Dec 27, 2022

marcwrobel Dec 27, 2022

marcwrobel commented Dec 27, 2022

usta commented Feb 10, 2023

marcwrobel commented Feb 13, 2023

marcwrobel commented Oct 12, 2023 •

edited

Loading

[NewProduct] Motorola Mobility #1453

[NewProduct] Motorola Mobility #1453

Conversation

moviuro commented Aug 2, 2022

captn3m0 commented Aug 2, 2022

captn3m0 commented Oct 17, 2022

moviuro commented Oct 17, 2022

captn3m0 commented Oct 17, 2022

captn3m0 commented Oct 17, 2022

usta commented Oct 18, 2022 • edited Loading

usta left a comment

Choose a reason for hiding this comment

captn3m0 commented Oct 18, 2022

usta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcwrobel commented Dec 12, 2022

marcwrobel commented Dec 12, 2022

captn3m0 commented Dec 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcwrobel commented Dec 27, 2022

usta commented Feb 10, 2023

marcwrobel commented Feb 13, 2023

marcwrobel commented Oct 12, 2023 • edited Loading

usta commented Oct 18, 2022 •

edited

Loading

marcwrobel commented Oct 12, 2023 •

edited

Loading