Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we stop suppressing the override mistake for Function.prototype.apply? #474

Closed
erights opened this issue Sep 23, 2020 · 1 comment · Fixed by #475
Closed

Should we stop suppressing the override mistake for Function.prototype.apply? #474

erights opened this issue Sep 23, 2020 · 1 comment · Fixed by #475

Comments

@erights
Copy link
Contributor

erights commented Sep 23, 2020

At https://github.com/Agoric/SES-shim/blob/9a7a0975036d8d938263ba265f747876d7d91599/packages/ses/src/enablements.js#L67 we say that we added Function.prototype.apply to the enablements whitelist because of tape.

At #473 (comment) @ljharb says that tape does not do an overriding assign to apply. If tape is no longer a problem, or if we were mistaken about whether it was a problem in the first place, and if we do not encounter any other such problems, we should remove Function.prototype.apply from the enablements whitelist.

@ljharb
Copy link

ljharb commented Sep 23, 2020

As far as I can discern, tape has never done an assignment to apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants