Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal_by_hdr_and_img_gz fails on Windows #27

Closed
nilgoyette opened this issue Nov 21, 2018 · 3 comments
Closed

minimal_by_hdr_and_img_gz fails on Windows #27

nilgoyette opened this issue Nov 21, 2018 · 3 comments

Comments

@nilgoyette
Copy link
Collaborator

This is not a new problem, I just waited a long time to report it.

When I run cargo test --release --features ndarray_volumes, minimal_by_hdr_and_img_gz fails on Windows and WSL. Moreover, it stops the other tests from running. To see the tests from volume.rs and writer.rs, I must remove the minimal_by_hdr_and_img_gz test.

I didn't investigate yet but I'm probably the only one with Windows so I'll do that "soon". What we could do to confirm the problem is to tell travis to test all OS. They added Windows support in the last months.

os:
  - windows
  - linux
  - osx
language: rust
...
@Enet4
Copy link
Owner

Enet4 commented Nov 21, 2018

Is this a different issue from #4? But yes, whatever the problem is here, we could add osx and windows to Travis.

@nilgoyette
Copy link
Collaborator Author

Hahaha, wow, I totally forgot about this issue. I'll confirm that it has the same cause and, if so, I'll fix the tests. We can't really ask other contributors or travis to use the hack you suggested.

@Enet4
Copy link
Owner

Enet4 commented Dec 5, 2018

Closing as fixed by #29.

@Enet4 Enet4 closed this as completed Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants