Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict (not-)equal checks #1092

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ximex
Copy link
Contributor

@ximex ximex commented Feb 6, 2023

use strict (not-)equal checks in db/, src/, tests/
unit tests still works

@MyIgel MyIgel added the Status: Needs discussion Additional discussion/feedback is needed label Feb 7, 2023
@MyIgel
Copy link
Member

MyIgel commented Feb 8, 2023

To be honest i don't see a good reason her (besides having to type more characters and remember to do so). SO we are here at a discussion of basics which should literally be an issue instead of a PR

@ximex
Copy link
Contributor Author

ximex commented Feb 11, 2023

sorry but typing one more char is no real argument for me to reject this change. the remembering argument is solved by the phpcs rule.
Using only == or != instead of === or !== could lead to problems if you compare things like 1 with '1' or want to differentiate '' and null and []. In every software project i worked with everyone also thought so that this is a good change.
see: https://www.php.net/manual/en/types.comparisons.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs discussion Additional discussion/feedback is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants