strict (not-)equal checks

.phpcs.xml

@@ -49,4 +49,7 @@
             <property name="spacesCountAroundEqualsSign" value="0" />
         </properties>
     </rule>
+    <rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators">
+        <exclude-pattern>/includes</exclude-pattern>
+    </rule>
 </ruleset>

db/migrations/2018_09_24_000000_create_event_config_table.php

@@ -32,7 +32,7 @@ public function up(): void
                     $table->timestamps();
                 });
             } catch (QueryException $e) {
-                if ($type != 'json') {
+                if ($type !== 'json') {
                     throw $e;
                 }
 

db/migrations/2022_12_15_000000_create_shifts_table.php

@@ -55,7 +55,7 @@ public function up(): void
             ->get();
         foreach ($records as $record) {
             $isUpdated = !empty($record->edited_at_timestamp)
-                && $record->edited_at_timestamp != $record->created_at_timestamp;
+                && $record->edited_at_timestamp !== $record->created_at_timestamp;
 
             $connection->table('shifts')->insert([
                 'id'             => $record->SID,

src/Controllers/Admin/UserWorkLogController.php

@@ -47,7 +47,7 @@ public function editWorklog(Request $request): Response
         if (isset($worklogId)) {
             $worklog = $this->worklog->findOrFail((int) $worklogId);
 
-            if ($worklog->user->id != $userId) {
+            if ($worklog->user->id !== $userId) {
                 throw new HttpNotFound();
             }
             return $this->showEditWorklog($user, $worklog->worked_at, $worklog->hours, $worklog->comment, true);
@@ -72,7 +72,7 @@ public function saveWorklog(Request $request): Response
         if (isset($worklogId)) {
             $worklog = $this->worklog->findOrFail((int) $worklogId);
 
-            if ($worklog->user->id != $userId) {
+            if ($worklog->user->id !== $userId) {
                 throw new HttpNotFound();
             }
         } else {
@@ -99,7 +99,7 @@ public function showDeleteWorklog(Request $request): Response
         $user = $this->user->findOrFail($userId);
         $worklog = $this->worklog->findOrFail($worklogId);
 
-        if ($worklog->user->id != $userId) {
+        if ($worklog->user->id !== $userId) {
             throw new HttpNotFound();
         }
 
@@ -116,7 +116,7 @@ public function deleteWorklog(Request $request): Response
 
         $worklog = $this->worklog->findOrFail($worklogId);
 
-        if ($worklog->user->id != $userId) {
+        if ($worklog->user->id !== $userId) {
             throw new HttpNotFound();
         }
         $worklog->delete();

src/Controllers/MessagesController.php

@@ -55,7 +55,7 @@ public function listConversations(): Response
 
         $conversations = [];
         foreach ($latestMessages as $msg) {
-            $otherUser = $msg->user_id == $currentUser->id ? $msg->receiver : $msg->sender;
+            $otherUser = $msg->user_id === $currentUser->id ? $msg->receiver : $msg->sender;
             $unreadMessages = $numberOfUnreadMessages[$otherUser->id] ?? 0;
 
             $conversations[] = [
@@ -114,7 +114,7 @@ public function messagesOfConversation(Request $request): Response
             ->get();
 
         $unreadMessages = $messages->filter(function ($m) use ($otherUser) {
-            return $m->user_id == $otherUser->id && !$m->read;
+            return $m->user_id === $otherUser->id && !$m->read;
         });
 
         foreach ($unreadMessages as $msg) {
@@ -146,7 +146,7 @@ public function send(Request $request): Response
         $newMessage->sender()->associate($currentUser);
         $newMessage->receiver()->associate($otherUser);
         $newMessage->text = $data['text'];
-        $newMessage->read = $otherUser->id == $currentUser->id; // if its to myself, I obviously read it.
+        $newMessage->read = $otherUser->id === $currentUser->id; // if its to myself, I obviously read it.
         $newMessage->save();
 
         return $this->redirect->to('/messages/' . $otherUser->id . '#newest');
@@ -164,7 +164,7 @@ public function delete(Request $request): Response
         $currentUser = $this->auth->user();
         $msg = $this->message->findOrFail($msgId);
 
-        if ($msg->user_id == $currentUser->id) {
+        if ($msg->user_id === $currentUser->id) {
             $msg->delete();
         } else {
             throw new HttpForbidden('You can not delete a message you haven\'t send');

src/Controllers/Metrics/Controller.php

@@ -209,7 +209,7 @@ public function stats(): Response
     protected function checkAuth(bool $isJson = false): void
     {
         $apiKey = $this->config->get('api_key');
-        if (empty($apiKey) || $this->request->get('api_key') == $apiKey) {
+        if (empty($apiKey) || $this->request->get('api_key') === $apiKey) {
             return;
         }
 

src/Controllers/Metrics/MetricsEngine.php

@@ -46,7 +46,7 @@ public function get(string $path, array $data = []): string
             foreach ($list as $row) {
                 $row = $this->expandData($row);
 
-                if ($type == 'histogram') {
+                if ($type === 'histogram') {
                     $return = array_merge($return, $this->formatHistogram($row, $name));
 
                     continue;
@@ -177,7 +177,7 @@ protected function escape(mixed $value): mixed
 
     public function canRender(string $path): bool
     {
-        return $path == '/metrics';
+        return $path === '/metrics';
     }
 
     /**

src/Controllers/NewsController.php

@@ -102,7 +102,7 @@ public function deleteComment(Request $request): Response
 
         $comment = $this->comment->findOrFail($commentId);
         if (
-            $comment->user->id != $this->auth->user()->id
+            $comment->user->id !== $this->auth->user()->id
             && !$this->auth->can('admin_news')
             && !$this->auth->can('comment.delete')
         ) {

src/Controllers/OAuthController.php

@@ -116,13 +116,13 @@ public function index(Request $request): Response
         }
 
         $user = $this->auth->user();
-        if ($oauth && $user && $user->id != $oauth->user_id) {
+        if ($oauth && $user && $user->id !== $oauth->user_id) {
             throw new HttpNotFound('oauth.already-connected');
         }
 
         $connectProvider = $this->session->get('oauth2_connect_provider');
         $this->session->remove('oauth2_connect_provider');
-        if (!$oauth && $user && $connectProvider && $connectProvider == $providerName) {
+        if (!$oauth && $user && $connectProvider && $connectProvider === $providerName) {
             $oauth = new OAuth([
                 'provider'      => $providerName,
                 'identifier'    => $resourceId,

src/Controllers/QuestionsController.php

@@ -63,7 +63,7 @@ public function delete(Request $request): Response
         );
 
         $question = $this->question->findOrFail($data['id']);
-        if ($question->user->id != $this->auth->user()->id) {
+        if ($question->user->id !== $this->auth->user()->id) {
             throw new HttpForbidden();
         }
 

src/Controllers/SettingsController.php

@@ -132,7 +132,7 @@ public function savePassword(Request $request): Response
 
         if (!empty($user->password) && !$this->auth->verifyPassword($user, $data['password'])) {
             $this->addNotification('auth.password.error', NotificationType::ERROR);
-        } elseif ($data['new_password'] != $data['new_password2']) {
+        } elseif ($data['new_password'] !== $data['new_password2']) {
             $this->addNotification('validation.password.confirmed', NotificationType::ERROR);
         } else {
             $this->auth->setPassword($user, $data['new_password']);

src/Events/Listener/OAuth2.php

@@ -86,7 +86,7 @@ protected function syncTeams(string $providerName, User $user, array $ssoTeam):
             return;
         }
 
-        if ($userAngeltype->pivot->supporter != $supporter) {
+        if ($userAngeltype->pivot->supporter !== $supporter) {
             $userAngeltype->pivot->supporter = $supporter;
             $userAngeltype->pivot->save();
 

src/Exceptions/Handlers/Legacy.php

@@ -27,7 +27,7 @@ public function report(Throwable $e): void
             $this->stripBasePath($e->getFile()),
             $e->getLine(),
             $previous ? $previous->getMessage() : 'None',
-            json_encode($e->getTrace(), PHP_SAPI == 'cli' ? JSON_PRETTY_PRINT : 0)
+            json_encode($e->getTrace(), PHP_SAPI === 'cli' ? JSON_PRETTY_PRINT : 0)
         ));
 
         if (is_null($this->log)) {

src/Helpers/ConfigureEnvironmentServiceProvider.php

@@ -22,7 +22,7 @@ public function register(): void
         $this->setTimeZone($timezone);
 
         $this->displayErrors(false);
-        if ($config->get('environment') == 'development') {
+        if ($config->get('environment') === 'development') {
             $this->displayErrors(true);
             $this->errorReporting(E_ALL);
             $this->setupDevErrorHandler();

src/Helpers/Schedule/XmlParser.php

@@ -88,7 +88,7 @@ protected function parseEvents(array $eventElements, Room $room): array
 
             $recording = '';
             $recordingElement = $event->xpath('recording');
-            if ($recordingElement && $this->getFirstXpathContent('optout', $recordingElement[0]) == 'false') {
+            if ($recordingElement && $this->getFirstXpathContent('optout', $recordingElement[0]) === 'false') {
                 $recording = $this->getFirstXpathContent('license', $recordingElement[0]);
             }
 

src/Http/Request.php

@@ -58,7 +58,7 @@ public function path(): string
     {
         $pattern = trim($this->getPathInfo(), '/');
 
-        return $pattern == '' ? '/' : $pattern;
+        return $pattern === '' ? '/' : $pattern;
     }
 
     /**

src/Http/Response.php

@@ -104,7 +104,7 @@ public function withView(string $view, array $data = [], int $status = 200, arra
 
         $new = clone $this;
         $new->setContent($this->renderer->render($view, $data));
-        $new->setStatusCode($status, ($status == $this->getStatusCode() ? $this->statusText : null));
+        $new->setStatusCode($status, ($status === $this->getStatusCode() ? $this->statusText : null));
 
         foreach ($headers as $key => $values) {
             $new = $new->withAddedHeader($key, $values);

src/Http/SessionServiceProvider.php

@@ -71,6 +71,6 @@ protected function getSessionStorage(): SessionStorageInterface
      */
     protected function isCli(): bool
     {
-        return PHP_SAPI == 'cli' || PHP_SAPI == 'phpdbg';
+        return PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg';
     }
 }

src/Middleware/RouteDispatcher.php

@@ -43,15 +43,15 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
         $route = $this->dispatcher->dispatch($request->getMethod(), $path);
 
         $status = $route[0];
-        if ($status == FastRouteDispatcher::NOT_FOUND) {
+        if ($status === FastRouteDispatcher::NOT_FOUND) {
             if ($this->notFound instanceof MiddlewareInterface) {
                 return $this->notFound->process($request, $handler);
             }
 
             return $this->response->withStatus(404);
         }
 
-        if ($status == FastRouteDispatcher::METHOD_NOT_ALLOWED) {
+        if ($status === FastRouteDispatcher::METHOD_NOT_ALLOWED) {
             $methods = $route[1];
             return $this->response
                 ->withStatus(405)

src/Middleware/RouteDispatcherServiceProvider.php

@@ -23,7 +23,7 @@ public function register(): void
             'cacheFile' => $this->app->get('path.cache.routes'),
         ];
 
-        if ($config->get('environment') == 'development') {
+        if ($config->get('environment') === 'development') {
             $options['cacheDisabled'] = true;
         }
 

src/Renderer/Twig/Extensions/Develop.php

@@ -22,7 +22,7 @@ public function __construct(protected Config $config)
      */
     public function getFunctions(): array
     {
-        if ($this->config->get('environment') != 'development') {
+        if ($this->config->get('environment') !== 'development') {
             return [];
         }
 

src/Renderer/TwigServiceProvider.php

@@ -83,7 +83,7 @@ protected function registerTwigEngine(): void
 
         $cache = $this->app->get('path.cache.views');
         $twigDebug = false;
-        if ($config->get('environment') == 'development') {
+        if ($config->get('environment') === 'development') {
             $cache = false;
             $twigDebug = true;
         }

tests/Unit/Controllers/MessagesControllerTest.php

@@ -173,7 +173,7 @@ public function testIndexWithConversationsOnlyContainsConversationsWithMe(): voi
                 $this->assertEquals(2, count($conversations));
                 $msg0 = $conversations[0]['latest_message']->text;
                 $msg1 = $conversations[1]['latest_message']->text;
-                $this->assertTrue(($msg0 == 'a>b' && $msg1 == 'c>a') || ($msg1 == 'c>a' && $msg0 == 'a>b'));
+                $this->assertTrue(($msg0 === 'a>b' && $msg1 === 'c>a') || ($msg1 === 'c>a' && $msg0 === 'a>b'));
 
                 return $this->response;
             });
@@ -540,7 +540,7 @@ public function setUp(): void
 
     protected function assertArrayOrCollection(mixed $obj): void
     {
-        $this->assertTrue(gettype($obj) == 'array' || $obj instanceof Collection);
+        $this->assertTrue(gettype($obj) === 'array' || $obj instanceof Collection);
     }
 
     protected function createMessage(User $from, User $to, string $text, Carbon $at): Message

tests/Unit/Helpers/Stub/UserModelImplementation.php

@@ -19,7 +19,7 @@ class UserModelImplementation extends User
 
     public function find(mixed $id, array $columns = ['*']): ?User
     {
-        if ($id != static::$id) {
+        if ($id !== static::$id) {
             throw new InvalidArgumentException('Wrong user ID searched');
         }
 
@@ -31,7 +31,7 @@ public function find(mixed $id, array $columns = ['*']): ?User
      */
     public static function whereApiKey(string $apiKey): array|Collection|QueryBuilder
     {
-        if ($apiKey != static::$apiKey) {
+        if ($apiKey !== static::$apiKey) {
             throw new InvalidArgumentException('Wrong api key searched');
         }
 

tests/Unit/Helpers/Translation/TranslatorTest.php

@@ -114,7 +114,7 @@ public function testReplaceText(): void
             ->method('gettext')
             ->willReturnCallback(function () use (&$i) {
                 $i++;
-                if ($i != 4) {
+                if ($i !== 4) {
                     throw new TranslationNotFound();
                 }
 

tests/Unit/Middleware/RouteDispatcherServiceProviderTest.php

@@ -58,7 +58,7 @@ public function testRegister(): void
                     $subject();
                 }
 
-                return is_callable($subject) || $subject == LegacyMiddleware::class;
+                return is_callable($subject) || $subject === LegacyMiddleware::class;
             }));
 
         /** @var RouteDispatcherServiceProvider|MockObject $serviceProvider */

tests/Unit/Renderer/Twig/Extensions/ExtensionTest.php

@@ -23,7 +23,7 @@ abstract class ExtensionTest extends TestCase
     protected function assertFilterExists(string $name, callable $callback, array $functions): void
     {
         foreach ($functions as $function) {
-            if ($function->getName() != $name) {
+            if ($function->getName() !== $name) {
                 continue;
             }
 
@@ -47,7 +47,7 @@ protected function assertExtensionExists(
         array $options = []
     ): void {
         foreach ($functions as $function) {
-            if ($function->getName() != $name) {
+            if ($function->getName() !== $name) {
                 continue;
             }