Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging System is clunky #2

Closed
paked opened this issue Dec 10, 2014 · 1 comment
Closed

Messaging System is clunky #2

paked opened this issue Dec 10, 2014 · 1 comment

Comments

@paked
Copy link
Member

paked commented Dec 10, 2014

Currently when subscribing to an event you pass in the system and the event name. This is clunky and leads to too much message confirmation logic in the default System.Receive(msg Message) handler.

My proposal is to pass a type func(msg Message) when subscribing to an event instead.

Any objections?
@paked paked closed this as completed Dec 31, 2014
@mewmew
Copy link
Contributor

mewmew commented Apr 22, 2016

For future reference, the proposal was implemented with commit 8d2cc58 as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mewmew @paked