Sanitize headline #1550
Merged
Sanitize headline #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2022
| Q | A | ------------- | --- | Bug fix? | yes | Backport | 0.9, 0.10 | Tickets | #1543 | License | MIT According to #1543, there is a security issue where xss code can be executed in frontend. Enhavo already provide a twig filter `html_sanitize` to prevent xss injections, but in this case the filter is not applied to the output of the `headline` filter. The `headline` filter is marked as html safe, which is not true. To unmark it as html safe will cause bc breaks because the output will be encoded html. So we apply the sanitize routine to the headline filter to satisfy the html safe mark. Further outputs where checked as well and the `raw` filter was replaced with `html_sanitize` where html output from the user is expected. (cherry picked from commit 33c68ba)
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2022
| Q | A | ------------- | --- | Bug fix? | yes | Backport | 0.9, 0.10 | Tickets | #1543 | License | MIT According to #1543, there is a security issue where xss code can be executed in frontend. Enhavo already provide a twig filter `html_sanitize` to prevent xss injections, but in this case the filter is not applied to the output of the `headline` filter. The `headline` filter is marked as html safe, which is not true. To unmark it as html safe will cause bc breaks because the output will be encoded html. So we apply the sanitize routine to the headline filter to satisfy the html safe mark. Further outputs where checked as well and the `raw` filter was replaced with `html_sanitize` where html output from the user is expected. (cherry picked from commit 33c68ba)
Closed
gseidel
added a commit
that referenced
this pull request
May 2, 2022
| Q | A | ------------- | --- | Bug fix? | yes | Backport | 0.9, 0.10 | Tickets | #1543 | License | MIT According to #1543, there is a security issue where xss code can be executed in frontend. Enhavo already provide a twig filter `html_sanitize` to prevent xss injections, but in this case the filter is not applied to the output of the `headline` filter. The `headline` filter is marked as html safe, which is not true. To unmark it as html safe will cause bc breaks because the output will be encoded html. So we apply the sanitize routine to the headline filter to satisfy the html safe mark. Further outputs where checked as well and the `raw` filter was replaced with `html_sanitize` where html output from the user is expected. (cherry picked from commit 33c68ba) Co-authored-by: Gerhard Seidel <gseidel.message@googlemail.com>
gseidel
added a commit
that referenced
this pull request
May 2, 2022
| Q | A | ------------- | --- | Bug fix? | yes | Backport | 0.9, 0.10 | Tickets | #1543 | License | MIT According to #1543, there is a security issue where xss code can be executed in frontend. Enhavo already provide a twig filter `html_sanitize` to prevent xss injections, but in this case the filter is not applied to the output of the `headline` filter. The `headline` filter is marked as html safe, which is not true. To unmark it as html safe will cause bc breaks because the output will be encoded html. So we apply the sanitize routine to the headline filter to satisfy the html safe mark. Further outputs where checked as well and the `raw` filter was replaced with `html_sanitize` where html output from the user is expected. (cherry picked from commit 33c68ba) Co-authored-by: Gerhard Seidel <gseidel.message@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #1543, there is a security issue where xss code can be executed in frontend. Enhavo already provide a twig filter
html_sanitizeto prevent xss injections, but in this case the filter is not applied to the output of theheadlinefilter. Theheadlinefilter is marked as html safe, which is not true. To unmark it as html safe will cause bc breaks because the output will be encoded html. So we apply the sanitize routine to the headline filter to satisfy the html safe mark.Further outputs where checked as well and the
rawfilter was replaced withhtml_sanitizewhere html output from the user is expected.