Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #166 that adds the ability to mutate the header data returned by the base proto model. I use it to give the column headers of the path editor's points list special icons. I hid the vertical header of the path points list table too because we don't actually want it and it started showing row numbers now that my implementation allows the base
QAbstractItemModel::headerData
to return the section number as a string forQt::DisplayRole
role. We can also use this later to translate the column headers displaying field names for i18n.I was also thinking that this could be static and fundies did mention I could just use the proto type name so that messages still get unique header data. However, I don't know what other kind of dynamic crap we might want to do so I decided not to make it static yet. Static doesn't exactly work with things like sorting and other transformations of the data.