Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path Point Fields Translation #189

Merged
merged 1 commit into from Sep 5, 2020
Merged

Conversation

RobertBColton
Copy link
Contributor

@RobertBColton RobertBColton commented Sep 3, 2020

This uses the header data override of #175 to translate the path point list column headers.

Master Pull
Path Point Columns Master Path Point Columns Pull

Copy link
Member

@JoshDreamland JoshDreamland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth writing a wrapper that binds the field and translates its qualified name.

@RobertBColton
Copy link
Contributor Author

RobertBColton commented Sep 5, 2020

That was actually what I said to fundies when we first added this in #167, that the mutable header data could be static mapped to the message type name. I know by qualified name you are referring to the field's full name with the message type name prefixed to the field name. fundies said we could actually do both too, and have the non static header data override the static header data. I decided to just do the non static behavior to start with because I wasn't sure, but what you are proposing could work I'm sure.
FieldDescriptor Fully Qualified Name

@RobertBColton RobertBColton merged commit 86bb197 into master Sep 5, 2020
@RobertBColton RobertBColton deleted the path-point-field-header branch September 5, 2020 23:50
@RobertBColton RobertBColton mentioned this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants