Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Tests Not Providing GTest Expect Exit Code #1844

Closed
RobertBColton opened this issue Aug 1, 2019 · 1 comment
Closed

CI Tests Not Providing GTest Expect Exit Code #1844

RobertBColton opened this issue Aug 1, 2019 · 1 comment
Assignees
@JoshDreamland
Labels
Bug Issues that are non fatal and occur at run time or compile time. Continuous Integration Related to CI services utilized and the related scripts. Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Reproducible Can be triggered determininistically by a discrete series of steps.

Comments

@RobertBColton
Copy link
Contributor

RobertBColton commented Aug 1, 2019 •
edited

It seems #1842 only fixed our SimpleTests with respect to expects.

First, it seems there is a regression in draw_getpixel I'll have to dig for.
https://travis-ci.org/enigma-dev/enigma-dev/jobs/566640806#L1749

Second, the expect isn't failing that test.
https://travis-ci.org/enigma-dev/enigma-dev/jobs/566640806#L1758

The reason is because the test harness's close_window must be ignoring the exit code.

enigma-dev/CommandLine/testing/Tests/draw_test.cpp

Line 18 in f57003e

test_harness->close_window();

enigma-dev/CommandLine/testing/Platform/TestHarness-X11.cpp

Line 100 in e1615e8

system(("wmctrl -i -c " + to_string(window_id)).c_str());

@RobertBColton RobertBColton added Reproducible Can be triggered determininistically by a discrete series of steps. Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Bug Issues that are non fatal and occur at run time or compile time. Continuous Integration Related to CI services utilized and the related scripts. labels Aug 1, 2019
@RobertBColton RobertBColton changed the title Simple Tests Not Providing GTest Expect Exit Code CI Tests Not Providing GTest Expect Exit Code Aug 1, 2019
RobertBColton referenced this issue Aug 1, 2019
@fundies @JoshDreamland
New CI (#1792)
a131434 
Changes up the CI to reduce total load on Travis and put us in a better place to upgrade to C++14.
This was referenced Aug 1, 2019
Merged
Merged
@RobertBColton
Copy link
Contributor Author

Closing as resolved by #1847.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshDreamland JoshDreamland

Labels
Bug Issues that are non fatal and occur at run time or compile time. Continuous Integration Related to CI services utilized and the related scripts. Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Reproducible Can be triggered determininistically by a discrete series of steps.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshDreamland @RobertBColton