Test Harness Game Return #1847
Merged
Test Harness Game Return #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertBColton
added
Bug
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
=======================================
Coverage 24.94% 24.94%
=======================================
Files 177 177
Lines 16776 16776
=======================================
Hits 4184 4184
Misses 12592 12592Continue to review full report at Codecov.
|
JoshDreamland
approved these changes
Aug 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #1844 by having the regular CI tests assert the game's return code.
It seems to have worked, as I tested bringing back fundies regression I fixed yesterday, and it caused the test harness job to fail.
https://travis-ci.org/enigma-dev/enigma-dev/jobs/567212206#L1767
Sometime soon we should look at deduplicating these cpp files as they have quite a bit of redundancy.