-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaderboards' entries need to have the same format output as GMS #2370
Comments
If the IDs should not be present, can't we simply remove that part of the code that includes the IDs in the output? |
No, we can't, that's a debugging output and it is important. I suggest you get GMS with Steamworks extension set up to better understand why we do this. |
So the issue is that GMS is doing some encryption kind of thing before outputting the ID's but the Enigma's Steamwork is just outputting the Real ID's ? |
exactly |
so should i just write some function that encrypts the id's ? or there is some specific format that is preffered ? |
I have no idea, I suggest you check the GMS output. For example, how can we output this id: |
this is the line that i got from GM Steamworks Extension repo Turns out they are just converting the value to a hex value before outputing |
Interesting!!! Let me check and confirm then. Thank you @sidling1 |
@sidling1 Can you create a PR asap? |
Just fixing the hex thing ? And to which branch should i do the changes |
@sidling1 Just the master branch |
Fixes #2370. Previously the userId of the steam users was shown as it is in integer form. Since this is not desirable, this PR converts the integer into a **hexadecimal number** , prepends it with `@i64@` and appends it with `$i64$` before getting output on the leaderboard. changed lines 53/54 in the [file](https://github.com/enigma-dev/enigma-dev/blob/3918af3dc40734465b355a7d52cb9f9f93f5a8d6/ENIGMAsystem/SHELL/Universal_System/Extensions/Steamworks/gameclient/utils/gc_leaderboards_score_downloaded_cookies.cpp#L53) to handle hex conversion.
GMS's output looks like this:
See the
userID
entry for each player. For exampleTomasJPereyra
, hisuserID
is@i64@110000108ae8556$i64$
.Currently, ENIGMA's Steamworks extension output contains the real ID, which is coming from leaderboard_entries[i].m_steamIDUser.ConvertToUint64().
ENIGMA's Output:
Note that I replaced all IDs with Zeros for privacy purposes.
I think the IDs shouldn't be the 64-bit number.
The text was updated successfully, but these errors were encountered: