fixes mem leak in xlib joysticks #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
- Coverage 10.81% 10.78% -0.03%
==========================================
Files 158 159 +1
Lines 17079 17082 +3
==========================================
- Hits 1847 1843 -4
- Misses 15232 15239 +7
Continue to review full report at Codecov.
|
|
Ready for merge |
| } | ||
| }; | ||
| static vector<e_joystick*> joysticks; | ||
|
|
||
| static vector<std::unique_ptr<e_joystick>> joysticks; |
There was a problem hiding this comment.
Storing a private container of unique_ptr is pretty tacky; what was wrong with freeing the pointer ourselves?
JoshDreamland
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.