Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Vertex/Index Buffer Fixes #1840

Closed
wants to merge 1 commit into from

Conversation

RobertBColton
Copy link
Contributor

@RobertBColton RobertBColton commented Jul 29, 2019

It has always been the case that Direct3D9 won't run the Minecraft example, this is not a new regression. The problem exhibited in that example is that it sometimes defines empty primitives on the model it uses to render the 3D world. We even have a debug message about that in the model class right now, which I am unsure of whether we should remove. Regardless, Direct3D9 breaks down because the API prevents you from allocating a vertex buffer of size 0 which is different from OpenGL.

Size of the vertex buffer, in bytes. For FVF vertex buffers, Length must be large enough to contain at least one vertex, but it need not be a multiple of the vertex size. Length is not validated for non-FVF buffers. See Remarks.
https://docs.microsoft.com/en-us/windows/win32/api/d3d9/nf-d3d9-idirect3ddevice9-createvertexbuffer

@RobertBColton RobertBColton added Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets. Experimental Features that are new and still being explored. labels Jul 29, 2019
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #1840 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1840   +/-   ##
=======================================
  Coverage   24.89%   24.89%           
=======================================
  Files         177      177           
  Lines       16743    16743           
=======================================
  Hits         4169     4169           
  Misses      12574    12574
Impacted Files Coverage Δ
...MAsystem/SHELL/Graphics_Systems/OpenGL1/vertex.cpp 69.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fcb1ce...ed6486e. Read the comment docs.

@RobertBColton RobertBColton deleted the empty-vertex-buffer-fixes branch December 31, 2020 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experimental Features that are new and still being explored. Graphics Game visuals including render state, geometry pipeline, rasterization, and related assets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant