BMP write bug fix #2101 #2289
Merged
BMP write bug fix #2101 #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fwrite_wrapper("\x20\0", 2, 1, bmp); | ||
| // x03 indicates compression method as BI_BITFIELDS | ||
| fwrite_wrapper("\x03\0\0\0", 4, 1, bmp); | ||
| fwrite_wrapper("\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", 20, 1, bmp); |
There was a problem hiding this comment.
nit: can you use constexpr char k48Zeros[48] = {}; for these buffers, instead of the arbitrarily-long string literals?
There was a problem hiding this comment.
Sure, will update that.
|
I've made the changes. |
Codecov Report
@@ Coverage Diff @@
## master #2289 +/- ##
==========================================
+ Coverage 35.25% 35.27% +0.02%
==========================================
Files 213 213
Lines 20460 20474 +14
==========================================
+ Hits 7213 7223 +10
- Misses 13247 13251 +4
Continue to review full report at Codecov.
|
fundies
approved these changes
Mar 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is the fix which updates the bmp header present in
image_save_bmp(...)method ofimage_formats.cppfrom 40 byteBITMAPINFOHEADERto 108 byteBITMAPV4HEADERto support transparency.Reference used for fix: BMP_Wiki.