add instance_create_depth #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertBColton
commented
Aug 16, 2023
| newinst->yprevious=inst->yprevious; newinst->xprevious=inst->xprevious; | ||
| newinst->xstart=inst->xstart; newinst->ystart=inst->ystart; | ||
| newinst->image_index=inst->image_index; newinst->image_speed=inst->image_speed; | ||
| newinst->visible=inst->visible; newinst->image_xscale=inst->image_xscale; newinst->image_yscale=inst->image_yscale; newinst->image_angle=inst->image_angle; | ||
| newinst->hspeed=inst->hspeed; newinst->vspeed=inst->vspeed; | ||
| if (perf) newinst->myevent_create(); |
There was a problem hiding this comment.
@JoshDreamland do you have proof that create was supposed to run before the variables were copied?
looks like plionz added it: 9e3060f
k0T0z
suggested changes
Aug 16, 2023
ENIGMAsystem/SHELL/Universal_System/Instances/instance_create.h
Outdated
Show resolved
Hide resolved
dc03
reviewed
Aug 16, 2023
Comment on lines
156
to
160
| newinst->yprevious=inst->yprevious; newinst->xprevious=inst->xprevious; | ||
| newinst->xstart=inst->xstart; newinst->ystart=inst->ystart; | ||
| newinst->image_index=inst->image_index; newinst->image_speed=inst->image_speed; | ||
| newinst->visible=inst->visible; newinst->image_xscale=inst->image_xscale; newinst->image_yscale=inst->image_yscale; newinst->image_angle=inst->image_angle; | ||
| newinst->hspeed=inst->hspeed; newinst->vspeed=inst->vspeed; |
There was a problem hiding this comment.
Uh, what is going on with the indentation formatting here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed
instance_copyso that it inits the copied variables before calling the create event.