Fixes keyboard_string #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der a part of the actual string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyboard string is supposed to remove characters when the backspace key is hit, we still support the enter key being a new line which GM does not. If users have a problem with this they can remove it themselves, locally, in their games. I simply check if keyboard_lastkey is hit, which works fine because if it's a char it will be changed anyway, and then remove the last charater. It behaves exactly the same as 8.1 and Studio where the first time it's pressed it will remove one and then when it's held down it goes faster, same with adding characters, behavior is perfectly the same. Please merge when ready.