Keyboard Fixes #747
Merged
Keyboard Fixes #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GM centers using the unscaled region dimensions to center the window so that window_default or window_center will work in fullscreen mode making the window centered if the user returns to windowed mode. Tested and confirmed on GM8.1
Also fixes keyboard_lastkey so that they both behave the same as GM8.1, also tested multiple keyboard key combinations and releases to ensure the behavior is implemented properly. Also fixed for XLIB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements keyboard_key and also fixes keyboard_lastkey so that they both behave the same as GM8.1, also tested multiple keyboard key combinations and releases to ensure the behavior is implemented properly. Also fixed for XLIB.
Tested on Win32 and XLIB (Ubuntu) with the following code in an object's draw event. I can confirm the changes work on both systems and behave the same as GM as expected now.
This pull request can be merged.
Note: Ignore the window_center commit, nothing was actually changed yet, I did it then undid it. Waiting to have a further discussion on the forums regarding removing the child window.