Fixes font glyph edge artifacts & scrolling issues #748
Conversation
Adds X/Y 0.01 offset to the projection ortho. Corrects font glyph edge artifacts as well as a 1px gap at the seams of tiled scrolling backgrounds as was observed by many users of NVIDIA cards. This was extensively tested by many users of NVIDIA, AMD, INTEL, iGPU & onboard cards. This does not have any adverse effects on anything else or for people who never experienced any issues.
Adds X/Y 0.01 offset to the projection ortho. Corrects font glyph edge artifacts as well as a 1px gap at the seams of tiled scrolling backgrounds as was observed by many users of NVIDIA cards. This was extensively tested by many users of NVIDIA, AMD, INTEL, iGPU & onboard cards. This does not have any adverse effects on anything else or for people who never experienced any issues.
JPierreS
changed the title
|
Ok, dont comment this out though, remove it. +// After many tests, it was shown this part is not necessary.
+// enigma::mv_matrix.translate(0.00f, 0.00f, 0.0f);And you also need to remove it from GL3ModelStruct, the 3 line comment above it too. Once you do that, this can be merged. |
Removed commented out code.
Removed lingering offset used in previous tests.
|
I removed the commented out code and the lingering offsets in the gl3modelstruct, guess since it was in the gl3modelstruct it did not bias any of my tests so far. |
JPierreS
changed the title
|
This pull request has been tested by myself and other users on multiple hardware configurations, and everything appears to be working good now. This can be merged. |
Fixes font glyph edge artifacts & scrolling issues ** PLEASE DO NOT MERGE YET**
Implements a + X/Y 0.01 offset to d3d projection ortho. This may help fix rounding issues on many NVIDIA cards, in OPENGL. Tested extensively by myself on different systems, and by many ENIGMA users with AMD & NVIDIA cards, and some with INTEL and onboard. I tested it on 2 different types of NVIDIA cards on 2 different driver revisions from years old to most recent. Also tested with iGPU (Intel HD4000).
as seen by many NVIDIA users, an issue that existed even without any offsets.
A discussion and testing can be found here:
http://enigma-dev.org/forums/index.php?topic=2022.0
So far positive feedback on phase 1 and phase 2, once it is established that there are no issues for AMD, NVIDIA and other users (iGPU, onboard) etc, I recommend this gets merged.
a .01 offset certainly is not big enough to cause issues. an EXE is provided in that topic to test font rendering, scrolling and other with the fixes applied.