This repository has been archived by the owner on Nov 26, 2022. It is now read-only.
Fix 'H' timeframe support #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 16, 2018
|
Thanks! We're organizing this in a separate branch along with #266 which is why we did not include in this version but this is super helpful. |
|
@lenak25 this looks good to me so I will be merging into develop and test. Please take a look as well on Sunday. |
|
Thanks @vonpupp for your PR! |
|
Thank you @lenak25. Yes, I am aware of such things, however I handle them internally on an intermediate layer I made for my algos on top of Catalyst. Unfortunately this layer doesn't fit within Catalyst itself, otherwise I would PR it also. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to support "H" timeframes.
The issue is explained in #114.