Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Validate for Enketo 2.8.0.oc-6 #104

Closed
pbowen-oc opened this issue Jan 17, 2022 · 5 comments
Closed

Update Validate for Enketo 2.8.0.oc-6 #104

pbowen-oc opened this issue Jan 17, 2022 · 5 comments
Assignees
Milestone

Comments

@pbowen-oc
Copy link

pbowen-oc commented Jan 17, 2022

Create a new tag for Validate that is compatible with Enketo 2.8.0.oc-6.

Tag updated to include that other update.

@pbowen-oc pbowen-oc added this to the Next milestone Jan 17, 2022
@pbowen-oc pbowen-oc changed the title Update Validate for Enketo 2.8.0.oc-5 Update Validate for Enketo 2.8.0.oc-6 Jan 24, 2022
@pbowen-oc
Copy link
Author

Create new version off of 1.13.1 tag, update the dependencies as below and create a new tag (1.13.1.oc-1)?

"enketo-transformer": "1.43.0",

"enketo-core": "github:enketo/enketo#753.18.4.oc"

@MartijnR
Copy link
Member

Since this version is not published you need to run npm run prepare manually, to generate a new client-side JS bundle (that includes the updated Enketo Core version).

@svadla-oc
Copy link

@MartijnR it looks like since npm v5, npm run prepare will be run automatically as part of npm install (https://docs.npmjs.com/cli/v8/using-npm/scripts#life-cycle-scripts). We are using npm v6. Could you please confirm if this command still needs to be run separately? If so, does it need to be run after the npm install command?

@MartijnR
Copy link
Member

Ah yes, you're right. I didn't know it ran upon npm install. No need to run it separately then!

@svadla-oc
Copy link

Great. Thanks for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants