Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAPI Schema for the REST API #6

Closed
mnhock opened this issue Jul 16, 2023 · 12 comments
Closed

Add OpenAPI Schema for the REST API #6

mnhock opened this issue Jul 16, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@mnhock
Copy link
Member

mnhock commented Jul 16, 2023

As part of improving our REST API documentation and providing a more standardized and comprehensive approach, we should integrate the OpenAPI Schema. The json should be under {schema}://{hostname}:{port}/api/public/schema.json and should be generated automatically.

@mnhock mnhock added the enhancement New feature or request label Jul 16, 2023
@Chizobaonorh
Copy link
Contributor

hello i would love to contribute to this.

@mnhock
Copy link
Member Author

mnhock commented Sep 2, 2023

Hello @Chizobaonorh! Great to see your here! Thanks, for contributing! Do you need more information? This ticket refers to all controllers with starting with Api*Controller. At the moment they must be two of them.

@Chizobaonorh
Copy link
Contributor

Hello i would love to contribute, i even started some contributions already, but to the general docs, i can make a pull request so you can see what i added to the documentation. And i would need to be guided hand-in-hand on how to go about running a request example and generating a response scheme to know what each response signifies. I would run that pull request now.

@mnhock
Copy link
Member Author

mnhock commented Sep 2, 2023

How to setup this project is described here: https://github.com/enofex/naikan/blob/main/DEVELOPING.md
Sample requests can be found here: https://github.com/enofex/naikan/blob/main/development/naikan-api.http
If the docker compose was started correctly you can see data in it and a configured valid bearer token as well. This you should use for the requests.

The PR is about generating the OpenAPI schema.json for the above described Controllers.

@Chizobaonorh
Copy link
Contributor

Okay would work in it now.

@Chizobaonorh
Copy link
Contributor

Chizobaonorh commented Sep 3, 2023

Hello i am encountering some issues setting up and starting the naikan application, I would need your assistance with that.
@mnhock

@enofex enofex deleted a comment from Chizobaonorh Sep 4, 2023
@Chizobaonorh
Copy link
Contributor

Hello, i am having an issue setting up to work on this project, from starting the naikan application and i would need assistance with that @mnhock

@mnhock
Copy link
Member Author

mnhock commented Sep 6, 2023

What is the exact problem? Have you installed and configured all prerequisites as described in the doc?

@enofex enofex deleted a comment from Chizobaonorh Sep 6, 2023
@Chizobaonorh
Copy link
Contributor

from the part of automatically starting dependencies with docker compose

@mnhock
Copy link
Member Author

mnhock commented Sep 6, 2023

You need docker desktop installed and then start the Spring Boot class described in the doc with the profile dev, -Dspring.profiles.active=dev as JVM parameter.

@Chizobaonorh
Copy link
Contributor

okay will try this out.

@Chizobaonorh
Copy link
Contributor

You need docker desktop installed and then start the Spring Boot class described in the doc with the profile dev, -Dspring.profiles.active=dev as JVM parameter.

I can't locate this, i need help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants