permissions update for published nodes #10420 #10428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## epic-node-patching #10428 +/- ##
========================================================
+ Coverage 84.56% 84.58% +0.02%
- Complexity 19610 19638 +28
========================================================
Files 2608 2610 +2
Lines 68037 68152 +115
Branches 5426 5433 +7
========================================================
+ Hits 57534 57648 +114
- Misses 7881 7883 +2
+ Partials 2622 2621 -1 ☔ View full report in Codecov by Sentry. |
vbradnitski
force-pushed
the
issue-10420
branch
from
f4a12b6
to
0aa1a03
Compare
rymsha
requested changes
Mar 4, 2024
modules/core/core-api/src/main/java/com/enonic/xp/content/ApplyContentPermissionsResult.java
Show resolved
Hide resolved
modules/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/NodeServiceImpl.java
Outdated
Show resolved
Hide resolved
...s/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/ApplyNodePermissionsCommand.java
Outdated
Show resolved
Hide resolved
modules/core/core-api/src/main/java/com/enonic/xp/node/ApplyNodePermissionsResult.java
Show resolved
Hide resolved
...re-content/src/main/java/com/enonic/xp/core/impl/content/ApplyContentPermissionsCommand.java
Show resolved
Hide resolved
...s/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/ApplyNodePermissionsCommand.java
Show resolved
Hide resolved
...s/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/ApplyNodePermissionsCommand.java
Outdated
Show resolved
Hide resolved
rymsha
reviewed
Mar 5, 2024
modules/core/core-api/src/main/java/com/enonic/xp/content/ApplyContentPermissionsParams.java
Outdated
Show resolved
Hide resolved
modules/core/core-api/src/main/java/com/enonic/xp/content/ApplyPermissionsListener.java
Outdated
Show resolved
Hide resolved
rymsha
reviewed
Mar 5, 2024
modules/core/core-content/src/main/java/com/enonic/xp/core/impl/content/ContentServiceImpl.java
Outdated
Show resolved
Hide resolved
modules/core/core-api/src/main/java/com/enonic/xp/content/ApplyPermissionsListener.java
Outdated
Show resolved
Hide resolved
rymsha
reviewed
Mar 5, 2024
...s/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/ApplyNodePermissionsCommand.java
Show resolved
Hide resolved
...s/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/ApplyNodePermissionsCommand.java
Outdated
Show resolved
Hide resolved
...s/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/ApplyNodePermissionsCommand.java
Outdated
Show resolved
Hide resolved
rymsha
reviewed
Mar 6, 2024
...re-content/src/main/java/com/enonic/xp/core/impl/content/ApplyContentPermissionsCommand.java
Outdated
Show resolved
Hide resolved
...s/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/ApplyNodePermissionsCommand.java
Outdated
Show resolved
Hide resolved
...s/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/ApplyNodePermissionsCommand.java
Show resolved
Hide resolved
rymsha
approved these changes
Mar 6, 2024
vbradnitski
added a commit
that referenced
this pull request
Apr 24, 2024
rymsha
pushed a commit
that referenced
this pull request
May 6, 2024
* remove inheritPermissions field #10424 * permissions update for published nodes #10420 (#10428) * get 'inheritPermissions' flag back for Node and Content #10442 * target branches are upgraded with obsolete version data #10454 * js api changes #10489 (#10493) * remove permissions from node/content modify flow #10443 (#10492) * merge with existing permissions #10494 (#10499) * applyPermissions - subtree selection #10485 (#10515) * rename mode to scope #10520 (#10521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.