Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js api changes #10489 #10493

Merged
merged 2 commits into from
Apr 2, 2024
Merged

js api changes #10489 #10493

merged 2 commits into from
Apr 2, 2024

Conversation

vbradnitski
Copy link
Contributor

No description provided.

@vbradnitski vbradnitski requested a review from rymsha April 1, 2024 09:39
@vbradnitski vbradnitski linked an issue Apr 1, 2024 that may be closed by this pull request
@vbradnitski vbradnitski requested a review from rymsha April 2, 2024 13:14
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (5fb38d2) to head (3517366).

Additional details and impacted files
@@                  Coverage Diff                  @@
##             epic-node-patching   #10493   +/-   ##
=====================================================
  Coverage                 84.57%   84.58%           
- Complexity                19639    19649   +10     
=====================================================
  Files                      2611     2613    +2     
  Lines                     68162    68198   +36     
  Branches                   5434     5434           
=====================================================
+ Hits                      57651    57688   +37     
+ Misses                     7889     7888    -1     
  Partials                   2622     2622           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbradnitski vbradnitski merged commit 074af4a into epic-node-patching Apr 2, 2024
6 checks passed
@vbradnitski vbradnitski deleted the issue-10489 branch April 2, 2024 13:54
vbradnitski added a commit that referenced this pull request Apr 24, 2024
rymsha pushed a commit that referenced this pull request May 6, 2024
* remove inheritPermissions field #10424

* permissions update for published nodes #10420 (#10428)

* get 'inheritPermissions' flag back for Node and Content #10442

* target branches are upgraded with obsolete version data #10454

* js api changes #10489 (#10493)

* remove permissions from node/content modify flow #10443 (#10492)

* merge with existing permissions #10494 (#10499)

* applyPermissions - subtree selection #10485 (#10515)

* rename mode to scope #10520 (#10521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve applyPermissions API
2 participants