remove permissions from node/content modify flow #10443 #10492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymsha
requested changes
Apr 2, 2024
modules/core/core-api/src/main/java/com/enonic/xp/node/EditableNode.java
Show resolved
Hide resolved
modules/core/core-api/src/main/java/com/enonic/xp/content/EditableContent.java
Show resolved
Hide resolved
modules/core/core-repo/src/main/java/com/enonic/xp/repo/impl/node/ImportNodeCommand.java
Outdated
Show resolved
Hide resolved
...s/core/core-security/src/main/java/com/enonic/xp/core/impl/security/SecurityServiceImpl.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## epic-node-patching #10492 +/- ##
=====================================================
Coverage 84.57% 84.58%
- Complexity 19639 19641 +2
=====================================================
Files 2611 2612 +1
Lines 68162 68175 +13
Branches 5434 5433 -1
=====================================================
+ Hits 57651 57663 +12
- Misses 7889 7890 +1
Partials 2622 2622 ☔ View full report in Codecov by Sentry. |
rymsha
approved these changes
Apr 2, 2024
vbradnitski
added a commit
that referenced
this pull request
Apr 24, 2024
rymsha
pushed a commit
that referenced
this pull request
May 6, 2024
* remove inheritPermissions field #10424 * permissions update for published nodes #10420 (#10428) * get 'inheritPermissions' flag back for Node and Content #10442 * target branches are upgraded with obsolete version data #10454 * js api changes #10489 (#10493) * remove permissions from node/content modify flow #10443 (#10492) * merge with existing permissions #10494 (#10499) * applyPermissions - subtree selection #10485 (#10515) * rename mode to scope #10520 (#10521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.