Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove whitespace in generated config.xml for rewrite #29

Closed
aligentjim opened this issue Jan 3, 2013 · 2 comments
Closed

Remove whitespace in generated config.xml for rewrite #29

aligentjim opened this issue Jan 3, 2013 · 2 comments

Comments

@aligentjim
Copy link

When generating a rewrite, Magicento generates

<rewrite>
    <some_class>
        Namespace_Extension_Model_Some_Class
    </some_class>
</rewrite>

When it should generate:

<rewrite>
    <some_class>Namespace_Extension_Model_Some_Class</some_class>
</rewrite>

The extra whitespace around the class name causes the factoryMethod (e.g. Mage::getSingleton to thrown an exception.

@enriquepiatti
Copy link
Owner

I can't reproduce this, I think this is related with the Wrap Text from PHPStorm.
Make sure you have this option unchecked:
Settings > Code Style > Xml > Other > Wrap text
Magicento will show you a warning about this if you try to use the autocomplete feature on any config.xml.

@aligentjim
Copy link
Author

Thanks for your help. Changing the Wrap Text parameter fixed the issue. I haven't used the autocomplete functionality in config.xml at all when I logged this issue, so it might be worth adding the same setting to the rewrite as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants